fixup! perf: reduce number of avatar requests

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
nextcloud · Dec 13, 2024 · d4f5514 · d4f5514
1 parent 3a3867b
commit d4f5514
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/IMAP/PreviewEnhancer.php b/lib/IMAP/PreviewEnhancer.php
@@ -65,7 +65,7 @@ public function process(Account $account, Mailbox $mailbox, array $messages): ar
 			if ($message->getStructureAnalyzed()) {
 				// Try fetching the avatar if it's not set
 				$from = $message->getFrom()->first() ;
-				if ($message->getAvatar() === null && $from !== null && $this->userId !== null) {
+				if ($message->getAvatar() === null && $from !== null && $from->getEmail() !== null && $this->userId !== null) {
 					$avatar = $this->avatarService->getAvatar($from->getEmail(), $this->userId);
 					$message->setAvatar($avatar);
 				}
@@ -114,10 +114,9 @@ public function process(Account $account, Mailbox $mailbox, array $messages): ar
 			$message->setMentionsMe($structureData->getMentionsMe());
 
 			$from = $message->getFrom()->first() ;
-			if ($message->getAvatar() === null && $from !== null && $this->userId !== null) {
-				$avatar = $this->avatarService->getAvatar($message->getFrom()->first()->getEmail(), $this->userId);
+			if ($message->getAvatar() === null && $from !== null && $from->getEmail() !== null && $this->userId !== null) {
+				$avatar = $this->avatarService->getAvatar($from->getEmail(), $this->userId);
 				$message->setAvatar($avatar);
-
 			}
 
 			return $message;