Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show first line of message as preview #2579

Closed
ChristophWurst opened this issue Jan 30, 2020 · 10 comments · Fixed by #7021
Closed

Show first line of message as preview #2579

ChristophWurst opened this issue Jan 30, 2020 · 10 comments · Fixed by #7021
Assignees
Labels
3. to review design enhancement skill:backend Issues and PRs that require backend development skills skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Jan 30, 2020

Feature Request

As any other decent IMAP client would do, our should also show the start of the first line of each message in the message list.

Summary

See above


Caveat: this operation is expensive. We have to fetch the body part. HTML message need special care.

In a later stage we can optimize to omit stuff like greetings or quoted text for bottom replies. For a start, the first line is good enough.

Implementation idea

We should fetch this data on demand, similar to the avatars. The data should then be written to the message cache #2064 (or memcache? 🤔) as it is immutable.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@ChristophWurst
Copy link
Member Author

Other products

Gmail


Outlook

Apple mail


Android


Source: https://litmus.com/blog/the-ultimate-guide-to-preview-text-support and google image search

@miaulalala
Copy link
Contributor

so this would actually work well with the propsed solution for the iMIP issues I'm fighting with at the moment:

#6802 (comment)

@ChristophWurst ChristophWurst self-assigned this Aug 8, 2022
@ChristophWurst
Copy link
Member Author

Backend part is done via #6962

@ChristophWurst
Copy link
Member Author

@nimishavijay @jancborchardt I believe we had mockups for this feature but I'm not able to find them. Could you post them here please for the frontend engineer?

@nimishavijay
Copy link
Member

I believe we had mockups for this feature but I'm not able to find them.

Actually we didn't. I'd say there should be one line under the subject in the same font size as the subject and in normal text (not bold) regardless of whether the email is unread or read.

image

cc @jancborchardt on this

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Aug 9, 2022

Frontend part 1/2 done via #6966

@ChristophWurst
Copy link
Member Author

@jancborchardt @nimishavijay where should the preview show on the right pane?

Bildschirmfoto vom 2022-08-17 11-17-07

I'm tempted to put it left of the date but the space is precious #7010

@jancborchardt
Copy link
Member

Preview should:

  • go in the subline below the sender
  • be in color-text-maxcontrast
  • only show for collapsed mails cause for expanded ones it would duplicate otherwise

Regarding soace, see my comment on the issue you linked.

@meichthys
Copy link

It would be nice if this was a configurable option. Most imap clients default to 1 line but have the option to disable or change the number of preview lines (usually between 0 and 3)

@ChristophWurst
Copy link
Member Author

Frontend part 2/2 done in #7021

Repository owner moved this from 🏗️ In progress to ☑️ Done in 💌 📅 👥 Groupware team Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review design enhancement skill:backend Issues and PRs that require backend development skills skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
7 participants