-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show message preview in envelope list #6966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and it works
af4d99d
to
dcdfda8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! :)
- The line-height is different between the 3 lines, there should be equal space between them. So essentially reduce the top padding/margin of the message preview a bit to match the distance between sender and subject.
- The avatar is not vertically centered with the first 2 lines (sender name and subject). And it probably looks nicer to vertically center it with the 3 lines now (sender name, subject, preview – but not the tags / attachments line). Ref like the screenshot of Gmail mobile you posted: Show first line of message as preview #2579 (comment)
- The message preview gets ellipsized nicely, but the message subject doesn’t seem to (also in master though), seen by @nimishavijay
I assume this also then goes into the thread list on the right in a separate PR?
Stupid but works: Not sure if this issue comes from the component? It’s not there in Contacts or Talk, but not sure what they use and it seems different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
I would say small css polishing can be done a bit later.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
19f8388
to
748bfc9
Compare
Contributes the envelope list part of #2579