Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show message preview in envelope list #6966

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Aug 9, 2022

Contributes the envelope list part of #2579

Bildschirmfoto vom 2022-08-10 14-37-27
Bildschirmfoto vom 2022-08-10 14-36-17
Bildschirmfoto vom 2022-08-10 14-36-15

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and it works

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :)

  • The line-height is different between the 3 lines, there should be equal space between them. So essentially reduce the top padding/margin of the message preview a bit to match the distance between sender and subject.
  • The avatar is not vertically centered with the first 2 lines (sender name and subject). And it probably looks nicer to vertically center it with the 3 lines now (sender name, subject, preview – but not the tags / attachments line). Ref like the screenshot of Gmail mobile you posted: Show first line of message as preview #2579 (comment)
  • The message preview gets ellipsized nicely, but the message subject doesn’t seem to (also in master though), seen by @nimishavijay

I assume this also then goes into the thread list on the right in a separate PR?

@jancborchardt
Copy link
Member

jancborchardt commented Aug 10, 2022

Looks good except the avatar is not vertically centered yet (both lines on the left are same length, both lines on right as well).
Judging from the lines on the right it also seems the container is a bit higher than necessary, just a few pixels (possibly an empty container for the tags display?)
mail alignment

@ChristophWurst
Copy link
Member Author

I think the problem is that around the actual avatar

Bildschirmfoto vom 2022-08-10 16-29-01

we have some bottom spacing

Bildschirmfoto vom 2022-08-10 16-28-58

although there is no margin or padding set. Ideas?

@jancborchardt
Copy link
Member

although there is no margin or padding set. Ideas?

Stupid but works:
.app-content-list-item-icon { height: 40px; }

Not sure if this issue comes from the component? It’s not there in Contacts or Talk, but not sure what they use and it seems different.

@ChristophWurst
Copy link
Member Author

I can't get it perfect to the last pixel but it looks ok now

Bildschirmfoto vom 2022-08-10 17-15-05

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!
I would say small css polishing can be done a bit later.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the enhancement/message-preview branch from 19f8388 to 748bfc9 Compare August 11, 2022 07:07
@ChristophWurst ChristophWurst merged commit f0c3b32 into main Aug 11, 2022
@ChristophWurst ChristophWurst deleted the enhancement/message-preview branch August 11, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants