Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect / Make it possible to delete several mails at once [$35] #890

Closed
hitam4450 opened this issue May 4, 2018 · 10 comments
Closed

Comments

@hitam4450
Copy link

hitam4450 commented May 4, 2018

Hi,
It would be very advantageous, if one could delete several mails at once and not only one by one !

regards, hitam4450


There is a $35 open bounty on this issue. Add to the bounty at Bountysource.

@laurentiu2
Copy link

Definitely needed. Also add the possibility to empty Trash and Spam more easily.

Laurentiu

@jospoortvliet jospoortvliet changed the title [Feature request] Make it possible to delete several mails at once [Feature request] Make it possible to delete several mails at once [$35] Apr 23, 2019
@ChristophWurst
Copy link
Member

To potential bounty hunters:

  1. Let us know when you plan working on this
  2. Let's discuss the implementation together
  3. Profit

@aharabara
Copy link

To potential bounty hunters:

1. Let us know when you plan working on this

2. Let's discuss the implementation together

3. …

4. Profit

Hi @ChristophWurst . I did a POC for this feature and you can checkout it from my fork on feature/890/bulk-operations branch. Use a to select/unselect messages and d to deselect all messages. All selected messages can be unseen, deleted and starred.
You can find it here

@ChristophWurst
Copy link
Member

@StCyr didn't you work on this?

@aharabara quick remarks:

@ChristophWurst
Copy link
Member

(wrong button, sorry)

@ChristophWurst
Copy link
Member

-> #2273 (comment)

@StCyr
Copy link
Collaborator

StCyr commented Jan 7, 2020

@StCyr didn't you work on this?

Yes, here: https://github.com/nextcloud/mail/tree/feature/2273/multi-select

@aharabara quick remarks:

* Selected state is something local. I wouldn't put that into the store.

I find it nice that he's using the 'selected' flag. I had try at first but couldn't succeed and you also told me to use something local.

What's the purpose of the 'selected' flag? It's not even use atm....

* The multi select feature is very useful for other apps as well. We should implement this in the components of https://github.com/nextcloud/nextcloud-vue

Wow, how do u imagine this?

@ChristophWurst
Copy link
Member

Wow, how do u imagine this?

We have existing components for the list and the items (though Mail uses its own implementation for the item right now), so we can add a prop selectable to the list or items components and if it's true then we offer this functionality. The list component will have the actions available for the selected items.

Does that make sense?

@jancborchardt
Copy link
Member

Interface-wise:

  • The action menu of each item should get an entry called "Select", which then triggers multiselect mode and selects that message.
  • In that mode, a select box is shown overlaying the avatar part of every message in the list. Clicking on the select box toggles the selection (of course), but the whole avatar part is click-sensitive for proper clickability/tappability.
  • Clicking the message part opens the message so you can check if you want to select that message. It’s important that you can still open messages in multiselect mode.
  • We show floating actions on the top just like for files. We should decide on 1 or max 2 ones which show directly there, with icon + text, and the rest shows in a 3-dot menu. Possible actions ("7" is a stand-in for the count of messages which we show as feedback. Is shorter than "Mark selected unread"):
    • "Favorite 7": Toggles with "Unfavorite 7". If all are favorited, directly show "Unfavorite 7".
    • "Mark 7 unread": Toggles with "Mark 7 read". If all are unread, directly show "Mark 7 read".
    • "Move 7"
    • "Deselect 7"
    • "Delete 7"

This seems to work well for Mail and also for e.g. Contacts and others (it’s also similar to what was discussed previously about how we do multiselect in the Files grid view). What do you think @ChristophWurst @GretaD @skjnldsv @ma12-co @nextcloud/designers?

@jancborchardt jancborchardt changed the title [Feature request] Make it possible to delete several mails at once [$35] Multiselect / Make it possible to delete several mails at once [$35] Feb 26, 2020
@ChristophWurst
Copy link
Member

Done via #2619. @StCyr please claim your well deserved bounty :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants