Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mails on mobile/touch devices #255

Closed
plastikschnitzer opened this issue Dec 18, 2016 · 20 comments
Closed

Move mails on mobile/touch devices #255

plastikschnitzer opened this issue Dec 18, 2016 · 20 comments

Comments

@plastikschnitzer
Copy link

plastikschnitzer commented Dec 18, 2016

#211 gives the option to move mails, but not on mobile/touch devices.

We need to discuss and find a way how to implement this feature here.

Here is an example how its solved in the samsung mail app, moving an email to the side opens some additional options like move mail, mark as unread and others:

screenshot_20161218-174638


Another way to implement is to give the option to select (multiple) emails and then have a menu which offers options like move mails, mark as …, delete and maybe others.

Best regards,
Plastikschnitzer

@plastikschnitzer plastikschnitzer mentioned this issue Dec 18, 2016
5 tasks
@ChristophWurst
Copy link
Member

summoning @jancborchardt @eppfel @juliushaertl 😀

@1337sup3rh4x0r
Copy link

How about a simple "move" button below the email (next to answer / forward buttons) that offers that list of folders when it is clicked this could also be used by people on desktops who are not that safe with drag and drop (thinking of my grandmother)

@stefan-niedermann
Copy link
Member

@plastikschnitzer nice idea but those kinds of swipe gestures are very hard to discover for a user. also swipe is often used to delete an item and users could be scared of do it.

@jancborchardt
Copy link
Member

jancborchardt commented Dec 20, 2016

We should do it exactly how we do it in the mobile interface of the Files app: A 3-dot-icon with the menu entries. The delete action etc can also go in there then.

(Edit: haha apparently it is possible to thumbs up your own comments. :D)

@plastikschnitzer
Copy link
Author

@stefan-niedermann Yes you are right, I discovered the swipe gesture by accident ...
@jancborchardt Thats good! May we also have an option for mass-select like in the file app if you delete files? Moving mails one by will get annoying if you have lots of emails.

@jospoortvliet jospoortvliet changed the title Move mails on mobile/touch devices Move mails on mobile/touch devices [$20] Aug 28, 2017
@jancborchardt
Copy link
Member

We now have a 3-dot action menu on every message, and a "Move" entry could just be added there, between "Mark read/unread" and "Delete".

This would open a modal picker with the list of folders to pick, much like the "Move or copy" action in Files which shows a file picker.


May we also have an option for mass-select like in the file app if you delete files? Moving mails one by will get annoying if you have lots of emails.

Yes, but multiselect is separate and discussed at #890 :)

@jancborchardt
Copy link
Member

Some more points:

  • In the action menu in the message list, as well as in the header in the detail view.
  • Both times, the action should be directly below the "Mark read/unread" action
  • It should open a modal with the folder list to pick the destination folder,
  • Ideally also separated by accounts so you could move messages between different accounts, if that is possible. In that case it would be good if the account where the mail is currently in is sorted up top so if you just want to move inside of that account, you can quickly do that without scrolling.

@ChristophWurst
Copy link
Member

Hey there,

I'd just like to let you know that due to the ongoing issue with Bountysource we're discussing ways to move to a different platform. As it looks right now, Bountysource might claim some of the money that was contributed by the community. We will try our best to prevent that. Historically we – the Nextcloud GmbH employees – simply put the claimed bounties back to other tickets until one was solved by a community member. So the money was always from the community and for the community. We'll therefore move to a better platform and currently don't post any new bounties until this situation is resolved. The current goal is to move/donate the money to Nextcloud include but details will follow in the forum post.

Hope this makes sense. If you have any questions please ask them on the forum. This comment will be copy-pasted to all open issues with bounties.

Christoph and the Mail team

@HLFH

This comment has been minimized.

@ChristophWurst ChristophWurst changed the title Move mails on mobile/touch devices [$20] Move mails on mobile/touch devices Jun 24, 2020
@st3iny
Copy link
Member

st3iny commented Sep 8, 2020

I'm willing to implement the move context menu item and the folder selection modal. I searched the nextcloud server repository for the file move modal code but couldn't find it. Does anyone here know if it is reusable or do I have to start from scratch?

@ChristophWurst
Copy link
Member

Hi @st3iny :)

You can find our current component library at https://github.com/nextcloud/nextcloud-vue. But we indeed do not have a folder picker yet, this is still the biggest blocker for this feature. However, there is a modal component that should be easy to use for this.

@dehnhardt
Copy link
Collaborator

I created a folderpicker for #3334. It is based on @riophae/vue-treeselect.
Maybe this is a starting point - and maybe we should create a separate branch for that.

@ChristophWurst
Copy link
Member

@dehnhardt awesome! Some quick remarks: let's use the term mailboxes consistently, I recently started to abandon "folder" to reduce the confusion, we'll only use this in user-facing strings. And you might want to change the method invoked by the mounted lifecycle hook into a simple computed property. That will also ensure that changes in the mailbox hierarchy propagate automagically :)

@st3iny
Copy link
Member

st3iny commented Sep 9, 2020

@dehnhardt Your component seems to be a good starting point. Should I wait for the associated pull request to be merged or can you merge it separately?

@ChristophWurst
Copy link
Member

maybe we should create a separate branch for th

Yeah and of course feel free to push that as a separate branch, though I'm unsure how we could test the component without making use of it yet

@dehnhardt
Copy link
Collaborator

@st3iny: To wait for that pull request would mean to wait several weeks. That's the reason why I suggested to make a separate branch with only that component.
@ChristophWurst: Yeah, hard to test on a separate branch. How is this done with other components?

@ChristophWurst
Copy link
Member

We typically only add them if we need them. Like on the feature branch directly.

@dehnhardt
Copy link
Collaborator

see PR: #3571

@dehnhardt
Copy link
Collaborator

Christoph recently merged the component into the master branch.

@st3iny
Copy link
Member

st3iny commented Sep 12, 2020

Awesome! I will start to work on the move feature as soon as possible.

@st3iny st3iny mentioned this issue Sep 15, 2020
@st3iny st3iny closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants