Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag'n'Drop support #2834

Closed
wants to merge 7 commits into from
Closed

Drag'n'Drop support #2834

wants to merge 7 commits into from

Conversation

StCyr
Copy link
Collaborator

@StCyr StCyr commented Mar 31, 2020

Drag'n'Drop support implementation with https://github.com/Vivify-Ideas/vue-draggable

Remaining issues:

  • It seems the code isn't properly initialized: If you load the mail apps from your browser, the drag'n'drop functionality won't work directly. You first have to perform an action (eg: selecting another email than the default one displayed) before the drag'n'drop functionality will work;
  • Shouldn't navigate when the moved message is not tghe one currently displayed
  • Do not expand when folder's account is not the same as envelope account
  • Polishing

This PR is a continuation of #1753

StCyr and others added 7 commits March 27, 2020 09:39
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
…over them

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@jancborchardt jancborchardt mentioned this pull request Mar 31, 2020
4 tasks
@jancborchardt jancborchardt changed the title [FEATURE] Drag'n'Drop support Drag'n'Drop support Mar 31, 2020
@StCyr
Copy link
Collaborator Author

StCyr commented Apr 16, 2020

Hello @jancborchardt

I don't know if D&D support is the best option we have to classify e-mails.

I was also thinking about adding a "move" action in the same way how it is done in the "file" app:

image

@jancborchardt

This comment has been minimized.

@jancborchardt
Copy link
Member

@StCyr fully agree → I moved my feedback into the issue which already exists about that: #255 (comment) :)

@StCyr
Copy link
Collaborator Author

StCyr commented Oct 4, 2020

This is very old and the move feature introduced in #3591 will solve the issue this PR tried to solve

@StCyr StCyr closed this Oct 4, 2020
@ChristophWurst ChristophWurst deleted the StCyr-Issue598 branch October 4, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants