MailboxPicker

[dehnhardt]

@ChristophWurst and @st3iny: I split the mailbox picker out of the big PR and incorporated Christoph's comments.
For viewing and testing I simply added a mailbox picker to the account settings. Before the merge we remove this ;-)

[ChristophWurst]

Suggested change

	let folders = []
	let mailboxes = []

for consistency :)

[dehnhardt]

We now need 2 arrays here...

[ChristophWurst]

Not necessarily. Instead of iterating on one array and filling another one (imperative coding) you can map the mailboxes to the new data structure and just return the result. No need to store anything a second time. If that's too much to ask then leave it and I can clean up the code later ✌️

[dehnhardt]

It's definitly not too much to ask, I simply do not understand how to do that. Can you give me a hint?

[ChristophWurst]

Then I'm sorry for not explaining it.

Currently you do

let mailboxes = ...
const boxLevel = []
mailboxes.forEach((folder) => {
    ...
    boxLevel.push({ ... })
})
return boxLevel

but you can simplify to

let mailboxes = ...
return mailboxes.map((mailbox) => {
    return {
        ...,
        children: this.getMailboxes(mailbox.databseId)
    }
})

[dehnhardt]

Wow, strange syntax ;-) Done!

[ChristophWurst]

Wörks nicely!

I guess we can improve the styling later on with icons and so on, but it's a great start. Thanks a lot!

[ChristophWurst]

Please remove the component from the settings page again, squash and rebase your comments then I'll integrate :)

[dehnhardt]

Please remove the component from the settings page again, squash and rebase your comments then I'll integrate :)

Done.