Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show recipients in each thread envelope #4315

Closed
wants to merge 2 commits into from

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jan 6, 2021

Ref #4258

Here is my suggestion for showing the recipients of individual envelopes in threads. The design is up for discussion.

cc @StCyr @ChristophWurst


EDIT: removed outdated gif

@StCyr
Copy link
Collaborator

StCyr commented Feb 21, 2021

#4258 (comment)

another important issue is that you don´t see who is in "from" and who is in "cc".
for example in gmail you have on the right side of this email list a small arrow.
when you click on this arrow you see in a popover who is in "from" and who is in "cc".
at the moment you don´t know if you where in cc or not.

@st3iny
Copy link
Member Author

st3iny commented Feb 22, 2021

I added a separate line for showing cc recipients. However, I can't come up with a nice way to add a toggle for the additional infos (e.g. cc).

Screenshot_2021-02-22 Mail - Nextcloud(1)

@st3iny st3iny marked this pull request as ready for review February 22, 2021 16:14
@st3iny st3iny force-pushed the enhancement/4258/show-thread-envelope-recipients branch from 5cc3d81 to 6107a97 Compare February 22, 2021 16:17
@StCyr
Copy link
Collaborator

StCyr commented Feb 22, 2021

I find it nice but it may take a lot of space on small screens

@ChristophWurst
Copy link
Member

Take a look at this. They have also a list of participants of a thread/message but only with the avatars. We discussed a few times that this is also our goal for the thread participants on top – how about we do the same for the recipients of an individual message?

@ChristophWurst ChristophWurst added this to the v1.9 milestone Feb 26, 2021
@kinimodmeyer
Copy link

kinimodmeyer commented Feb 26, 2021

can we not make such a icon with the informations?
(besides the space such a icon would also give you more freedom in show more information in future and also you can implement there a "copy & paste" e-mail list feature) :

gm

please also don´t forget to implement the BCC.
at the moment you can not see if you are in BCC.
gmail shows it this way:

gm2

@ChristophWurst ChristophWurst modified the milestones: v1.9, v1.10 Mar 3, 2021
@st3iny
Copy link
Member Author

st3iny commented Mar 4, 2021

please also don´t forget to implement the BCC.
at the moment you can not see if you are in BCC.

AFAIK, you cannot disclose the BCC of a received email.

@st3iny
Copy link
Member Author

st3iny commented Mar 4, 2021

Take a look at this. They have also a list of participants of a thread/message but only with the avatars. We discussed a few times that this is also our goal for the thread participants on top – how about we do the same for the recipients of an individual message?

We could do that. Our RecipientBubble component uses the UserBubble component from nextcloud-vue. I could implement a new parameter for UserBubble which allows to omit the label span and just show an avatar.

I moved the participant list to its own component (ThreadAvatarHeader) so all changes will be propagated to both participant/recipient lists.

@st3iny st3iny force-pushed the enhancement/4258/show-thread-envelope-recipients branch from 6107a97 to 451b8c6 Compare March 4, 2021 16:14
@kinimodmeyer
Copy link

kinimodmeyer commented Mar 4, 2021

please also don´t forget to implement the BCC.
at the moment you can not see if you are in BCC.

AFAIK, you cannot disclose the BCC of a received email.

when the sender don´t fill out the "to" but the sender fills out the "bcc" then the email has no "to".
in that case it would be good when nextcloud mail not "lying" and don´t display a "to".
(have a look at the picture i posted)

@st3iny

This comment has been minimized.

@st3iny st3iny force-pushed the enhancement/4258/show-thread-envelope-recipients branch from 451b8c6 to bd146d0 Compare March 4, 2021 19:20
@st3iny
Copy link
Member Author

st3iny commented Mar 4, 2021

@kinimodmeyer Hmm, I guess showing an empty to line is kind of pointless. I pushed a commit that removes the whole To: line when it's empty (just like CC).

@st3iny st3iny marked this pull request as draft March 4, 2021 19:37
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@jancborchardt
Copy link
Member

How about we only show that block for each thread envelope if it differs from the main thread?
We could even indicate what the difference is, e.g. "Richard Steinmetz was added" or "Christoph Wurst was removed", which would be great for security even, if someone is added.

This would be much more useful, since otherwise if we just show it for every single envelope, it’s mostly noise repeating the same info over and over again?

@ChristophWurst ChristophWurst modified the milestones: v1.10.0, v1.11.0 Jun 25, 2021
@ChristophWurst ChristophWurst modified the milestones: v1.11.0, v1.12.0 Nov 29, 2021
@ChristophWurst
Copy link
Member

@st3iny is this still blocked?

@st3iny
Copy link
Member Author

st3iny commented Mar 28, 2022

@st3iny is this still blocked?

We need to figure out how to implement/design it properly. But it's not blocked by dependencies or other PRs.

@ChristophWurst ChristophWurst removed this from the v1.12.0 milestone Apr 29, 2022
@jancborchardt
Copy link
Member

How about we only show that block for each thread envelope if it differs from the main thread? We could even indicate what the difference is, e.g. "Richard Steinmetz was added" or "Christoph Wurst was removed", which would be great for security even, if someone is added.

This would be much more useful, since otherwise if we just show it for every single envelope, it’s mostly noise repeating the same info over and over again?

@st3iny what do you think about my comment above?

@ChristophWurst
Copy link
Member

@st3iny 👀 😄

@ChristophWurst
Copy link
Member

so

@ChristophWurst
Copy link
Member

soo

@ChristophWurst
Copy link
Member

Design specs added to #4258 (comment). Let's do this

@ChristophWurst
Copy link
Member

I have spent 2h trying to get the specs from #4258 (comment) in.

It takes more effort to get this into a working state and making it look nice.

Closing.

@ChristophWurst ChristophWurst deleted the enhancement/4258/show-thread-envelope-recipients branch December 4, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ThreadEnvelope doesn't show sender, To, Cc,...
5 participants