-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show recipients in each thread envelope #4315
Conversation
|
5cc3d81
to
6107a97
Compare
I find it nice but it may take a lot of space on small screens |
Take a look at this. They have also a list of participants of a thread/message but only with the avatars. We discussed a few times that this is also our goal for the thread participants on top – how about we do the same for the recipients of an individual message? |
can we not make such a icon with the informations? please also don´t forget to implement the BCC. |
AFAIK, you cannot disclose the BCC of a received email. |
We could do that. Our RecipientBubble component uses the UserBubble component from nextcloud-vue. I could implement a new parameter for UserBubble which allows to omit the label span and just show an avatar. I moved the participant list to its own component (ThreadAvatarHeader) so all changes will be propagated to both participant/recipient lists. |
6107a97
to
451b8c6
Compare
when the sender don´t fill out the "to" but the sender fills out the "bcc" then the email has no "to". |
This comment has been minimized.
This comment has been minimized.
451b8c6
to
bd146d0
Compare
@kinimodmeyer Hmm, I guess showing an empty to line is kind of pointless. I pushed a commit that removes the whole |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
bd146d0
to
13ea21c
Compare
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
How about we only show that block for each thread envelope if it differs from the main thread? This would be much more useful, since otherwise if we just show it for every single envelope, it’s mostly noise repeating the same info over and over again? |
@st3iny is this still blocked? |
We need to figure out how to implement/design it properly. But it's not blocked by dependencies or other PRs. |
@st3iny what do you think about my comment above? |
@st3iny 👀 😄 |
so |
soo |
Design specs added to #4258 (comment). Let's do this |
I have spent 2h trying to get the specs from #4258 (comment) in. It takes more effort to get this into a working state and making it look nice. Closing. |
Ref #4258
Here is my suggestion for showing the recipients of individual envelopes in threads. The design is up for discussion.
cc @StCyr @ChristophWurst
EDIT: removed outdated gif