Show recipient avatars only in thread header #4704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this something we want to have? If so, I'd be happy to move on with the upstream PR :) |
|
@nimisha-vijay what do you think? :) |
|
This looks good actually! Although I am concerned about how informative this would be if a participant had a weird email address, because this does not show the name anywhere. With the way it is right now, we are able to identify each person quickly because their names are very easily visible. What do you think? |
|
I agree. It looks nice but losing the ability to quickly grasp participant email addresses isn't worth it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4315 (comment)
Requires nextcloud-libraries/nextcloud-vue#1745
A more compact thread participant header.