Fix sending erroneous message repeatedly #6602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
May 31, 2022
| $schema = $schemaClosure(); | ||
|
|
||
| $localMessageTable = $schema->getTable('mail_local_messages'); | ||
| $localMessageTable->addColumn('failed', 'boolean', [ |
There was a problem hiding this comment.
Does it make sense to add another column here to store some details about the error?
There was a problem hiding this comment.
We can, but how and what shall we store? The raw exception message can't be localized. We would need to have some specific errors that can be processed for the user, e.g. "Invalid recipient", then define error codes for them and show localized messages to the user.
As a first measure to prevent the endless resending of messages I would keep it simple and just have the boolean flag.
st3iny
reviewed
May 31, 2022
st3iny
reviewed
May 31, 2022
ChristophWurst
force-pushed
the
fix/erroneous-message-sent-repeatedly
branch
2 times, most recently
from
8181f2f to
660a657
Compare
|
/backport to stable1.13 |
|
/backport to stable1.12 |
st3iny
approved these changes
Jun 7, 2022
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/erroneous-message-sent-repeatedly
branch
from
b75275d to
0b0e905
Compare
This was referenced Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6540
Steps to test
invalidMaster: message is attempted to be sent again
Here: message is not sent a second time