Retrying to send fail messages (enh)

[sazanof]

Hello everyone!
I will be glad if you consider this improvement and give your comments. =)
Maybe it refers to #6401

Basically there are 2.5 improvements:

• Batch sending of emails with the failed status
• • The interface for sending a single message has been slightly redesigned
• Background sending of emails with the failed status when the page loads

And here are the screenshots:

Perhaps another processing logic is needed here, so I would like to discuss this.
Thanks!

[jancborchardt]

Very nice work! :) Design feedback:

• The "Retry" icon button on the right might be better as just a text-only tertiary button with text "Retry".
• The loading spinner doesn’t seem to be the standard one from the Vue components?
• For long subject or error subline, the text needs to be ellipsized a bit earlier to not overlap with the icon

[sazanof]

Very nice work! :) Design feedback:

• The "Retry" icon button on the right might be better as just a text-only tertiary button with text "Retry".
• The loading spinner doesn’t seem to be the standard one from the Vue components?
• For long subject or error subline, the text needs to be ellipsized a bit earlier to not overlap with the icon

@jancborchardt done. Please take a look.

[ChristophWurst]

this means with every page load we retry sending those messages. I'm not sure if this is how we want it.

shouldn't each message have some kind of retry counter so it's only retried a few times? with the first iteration of the outbox feature we continuously retried sending failed messages. but that caused more trouble than expected. so this was deliberately disabled via #6602.

also see #6540. there are some side effects with blindly resending ever pending message in the outbox.

[sazanof]

@ChristophWurst thank you! As you said, we can retry X-times to send messages only if message failed when it sent first time. In other cases, do not retry sending. What di you think?

In addition, if automatic sending is still not needed, can I leave the updated functionality for resending messages manually =)

[ChristophWurst]

Let's try with a counter 👍

[sazanof]

Hello everyone!
Is it better to turn on the counter when the page loads, or to attract something like a permanent storage (localstorage, database)? Although probably the latter has more chances for bugs?

[ChristophWurst]

I'd say the counter should be in the backend

[ChristophWurst]

also friendly ping here

[ChristophWurst]

#9364 and related handle this on the backend. The frontend trigger is obsolete