Skip to content

Commit

Permalink
Merge pull request #2832 from nextcloud/fix/neon_framework/request-ma…
Browse files Browse the repository at this point in the history
…nager-catch-expires-parsing

fix(neon_framework): Catch exceptions when parsing Expires header in RequestManager
  • Loading branch information
provokateurin authored Feb 25, 2025
2 parents 1263e39 + 111fd4f commit c02e3b9
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion packages/neon_framework/lib/src/utils/request_manager.dart
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,15 @@ class CacheParameters {
factory CacheParameters.parseHeaders(Map<String, dynamic> headers) {
tz.TZDateTime? expiry;
if (headers.containsKey('expires')) {
expiry = parseHttpDate(headers['expires']! as String);
try {
expiry = parseHttpDate(headers['expires']! as String);
} on FormatException catch (error, stackTrace) {
_log.finer(
'Failed to parse "Expires" header: "${headers['expires']}"',
error,
stackTrace,
);
}
}

return CacheParameters(
Expand Down

0 comments on commit c02e3b9

Please sign in to comment.