Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neon_framework): Catch exceptions when parsing Expires header in RequestManager #2832

Merged

Conversation

provokateurin
Copy link
Member

Saw a Parsing timezone can not be done unambiguously. flying by, but unfortunately there was no log which value was causing this.
If it happens we are fine to ignore it, since it's only caching that might not work as intended, but we can still log the error.

…RequestManager

Signed-off-by: provokateurin <kate@provokateurin.de>
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 29.07%. Comparing base (0ad5dae) to head (111fd4f).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../neon_framework/lib/src/utils/request_manager.dart 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2832      +/-   ##
==========================================
- Coverage   29.07%   29.07%   -0.01%     
==========================================
  Files         373      373              
  Lines      138403   138406       +3     
==========================================
  Hits        40243    40243              
- Misses      98160    98163       +3     
Flag Coverage Δ *Carryforward flag
account_repository 98.47% <ø> (ø)
cookie_store 99.48% <ø> (ø) Carriedforward from 0ad5dae
dashboard_app 96.05% <ø> (ø)
dynamite 31.05% <ø> (ø) Carriedforward from 0ad5dae
dynamite_end_to_end_test 61.79% <ø> (ø) Carriedforward from 0ad5dae
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 0ad5dae
interceptor_http_client 97.18% <ø> (ø) Carriedforward from 0ad5dae
neon_dashboard 96.05% <ø> (ø) Carriedforward from 0ad5dae
neon_framework 59.27% <25.00%> (-0.06%) ⬇️
neon_http_client 93.61% <ø> (ø) Carriedforward from 0ad5dae
neon_notifications 100.00% <ø> (ø) Carriedforward from 0ad5dae
neon_rich_text 100.00% <ø> (ø)
neon_storage 94.66% <ø> (ø) Carriedforward from 0ad5dae
neon_talk 99.45% <ø> (ø) Carriedforward from 0ad5dae
nextcloud 24.57% <ø> (ø) Carriedforward from 0ad5dae
notifications_app 97.36% <ø> (ø)
notifications_push_repository 98.11% <ø> (ø)
sort_box 90.90% <ø> (ø) Carriedforward from 0ad5dae
talk_app 98.84% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../neon_framework/lib/src/utils/request_manager.dart 74.69% <25.00%> (-2.81%) ⬇️

@provokateurin provokateurin merged commit c02e3b9 into main Feb 25, 2025
10 of 11 checks passed
@provokateurin provokateurin deleted the fix/neon_framework/request-manager-catch-expires-parsing branch February 25, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant