Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit/preview toggle #23

Closed
phsc84 opened this issue Dec 1, 2016 · 9 comments · Fixed by #315
Closed

Add edit/preview toggle #23

phsc84 opened this issue Dec 1, 2016 · 9 comments · Fixed by #315
Labels
enhancement New feature or request feature: editor Related to generic parts of the editor, e.g. loading/saving notes
Milestone

Comments

@phsc84
Copy link

phsc84 commented Dec 1, 2016

Sometimes you just want to read notes. Then it is more convenient if you can read it as formatted text without the whole markdown "noise".

The current implementation (simplemde branch, not yet merged) always shows the edit mode. This way I don't get why I need the Notes app. Because this is more or less the same as editing the notes with the default Nextcloud texteditor.

@phsc84
Copy link
Author

phsc84 commented Dec 1, 2016

Related to the pull request "Switch editor from mdedit to simplemde" #22

@stefan-niedermann
Copy link
Member

Just for information: Android client will do the exact same thing: nextcloud/notes-android#155

@jancborchardt
Copy link
Member

There could be a separate »reading« view, yes. But the edit mode should always be the default.

cc @Henni @korelstar what do you think? Something next to the fullscreen button maybe.

@Henni
Copy link
Member

Henni commented Dec 16, 2016

👍
@jancborchardt that's also where I would have placed that action.

@phsc84
Copy link
Author

phsc84 commented Dec 16, 2016

Great! Would be happy to have that feature.

@korelstar
Copy link
Member

But the edit mode should always be the default.

Yes, and I think it would be useful if the current mode (edit or preview) is kept active when loading another note -- until it is changed manually.

Something next to the fullscreen button maybe.

Definitely together with other buttons, and placing it next to the fullscreen button sounds really reasonable, since both buttons affect the representation of the note.

However, in the near future, it's likely to integrate more settings per note, e.g. a setting for the category of the note (#8). This is just meant as a hint to include this in our thoughts.

@jancborchardt
Copy link
Member

Yes, and I think it would be useful if the current mode (edit or preview) is kept active when loading another note -- until it is changed manually.

@korelstar I’d rather say that if at all, this should be remembered on a per-note basis. You might have some notes you’re only reading, and several notes you only edit.

We need to focus on that this is a Notes app, and edit mode also includes viewing anyway, but viewing mode does not include editing. So edit mode is always the choice in case of doubt.

@jancborchardt
Copy link
Member

The Markdown Editor app has this functionality: Editing view, Split view, or only Preview.

Maybe @icewind1991 can help with adding a preview mode here? Basically it’s also what happens when you share a Markdown file.

@jancborchardt jancborchardt added enhancement New feature or request and removed enhancement New feature or request feature request labels Jun 5, 2018
@korelstar korelstar added this to the 3.0.0 milestone May 21, 2019
@korelstar korelstar added the feature: editor Related to generic parts of the editor, e.g. loading/saving notes label May 24, 2019
@korelstar korelstar mentioned this issue May 26, 2019
3 tasks
@korelstar
Copy link
Member

Please have a look at #315 for an implementation of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature: editor Related to generic parts of the editor, e.g. loading/saving notes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants