-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preview mode #315
preview mode #315
Conversation
Looks great! Thank you for implementing this feature. |
Please have a look @nextcloud/designers / @jancborchardt : are the action buttons at bottom right fine? |
@korelstar the 3-dot button is fine, but for the actions in there, could you use the popover menu: https://docs.nextcloud.com/server/latest/developer_manual/design/popovermenu.html |
Even Better, the vue Actions component (Jan, at some point we will stop supporting the design html standards in favour of the vue components :) ) |
@jancborchardt @skjnldsv Good idea, thank! I will do that ... |
@jancborchardt Where is the best position for the three-dot-button? bottom-right or top-right? Background for this question: the |
I would say top right :) |
Agree with @skjnldsv, top-rigth. Reason being that whenever we have additional controls (like in the Files app or in the Talk app for example) they are always top right. |
Oh yes! Me likey!! 😍 |
@korelstar looks fabulous! Very well made :) |
This adds a preview mode, in which the formatted text is shown without any possibility to edit. Implementation uses
MarkdownIt
. Fixes #23.EditorMarkdownIt
for preview modeScreenshots
Normal editor (like before)
Action menu closed (bottom right)
Action menu opened (bottom right)
Action menu: Preview active (bottom right)
New Preview