-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Categories in navigation #210
Conversation
Oh, and please note: currently, only the first level of categories is shown in the navigation. E.g., if there are notes in the folders |
Hmm, the 2-level navigation is a bit confusing, and not fully necessary:
I would prefer to see mockups or sketches, no matter how quick and dirty, before we rush into implementation. :) That way we can see how stuff works, and don't waste work on things which don't. |
If you prefer to talk about mockups, then imagine that my implementation is a mockup ;-) In order to make the list slim, we could remove the favorites item, of course. And note, that the search will be (re)moved, too (see #43). But we cannot remove the recent item, since otherwise, you cannot go back from a specific category to the whole list of notes. We can rename this item though. However, the list of categories can be quite long (I'm using 11 first-level categories + uncategorized, in my personal notes). This would take much space from the screen (especially on mobile screens) and would require scrolling down in order to see the first notes items. We would have to go with a second navigation then, like in the contacts app. In my personal opinion, this would be too distracting when writing notes. But if you prefer this, we could go this way. I still think that my approach (showing categories on demand, using official Nextcloud design approaches) is best in giving access to categories and being not distracting when not using categories. What's your proposal? |
77ffef9
to
a333a47
Compare
updated screenshotsDefault view:... after clicking on "Categories" (collapsible):... after clicking on the category "Receipes":@jancborchardt Please have a look at the updated screenshots/mockups! I think this is a good solution, now! |
Looks really great! |
3106847
to
25c8849
Compare
25c8849
to
68e4fe8
Compare
68e4fe8
to
4391ead
Compare
absolutely, looks great! |
How do you set categories in the new method? Drag and drop, or right click on the note, or what? |
Also, since this is the last item for the 2.5.0 milestone, any chance we could get this wrapped up and usable please? :DDD |
Next step to provide categories to the frontend (see #8).
This PR is only about the navigation on the left side. The goal is to provide a list of existent categories with the possibility to filter the list of notes by the currently selected category. The design should orient on similar selectors of other Nextcloud apps as well as on the Android app. Changing the current note's category must be done in a separate PR (see #228).
Tasks done
Feedback
Please feel free to test and give feedback, especially from the design perspective. @nextcloud/designers @jancborchardt
I will also provide some screenshots ...