Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categories in navigation #210

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Categories in navigation #210

merged 1 commit into from
Nov 2, 2018

Conversation

korelstar
Copy link
Member

@korelstar korelstar commented Jun 23, 2018

Next step to provide categories to the frontend (see #8).

This PR is only about the navigation on the left side. The goal is to provide a list of existent categories with the possibility to filter the list of notes by the currently selected category. The design should orient on similar selectors of other Nextcloud apps as well as on the Android app. Changing the current note's category must be done in a separate PR (see #228).

Tasks done

  • show list of categories in the navigation bar (left side)
    • generate list from current notes
    • show only first level of categories
  • make these entries selectable
  • filter list of notes by current selection
  • show the number of notes per category as counter
  • when using the "New note" button, the new note is assigned automatically to the currently selected category
  • don't show favorites as navigation item (see discussion in the comments)
  • don't auto-close navigation after clicking on category (only on small screens)
  • group notes by category, if there is a sub-category (like in the Android app)

Feedback

Please feel free to test and give feedback, especially from the design perspective. @nextcloud/designers @jancborchardt
I will also provide some screenshots ...

@korelstar korelstar added enhancement New feature or request design Related to the design or user experience labels Jun 23, 2018
@korelstar
Copy link
Member Author

korelstar commented Jun 23, 2018

Screenshots of the first implementation

This is outdated! Please see the later comments for updated screenshots!

Default view:

... after clicking on "Categories" (collapsible):

... after clicking on the category "Test":

@korelstar
Copy link
Member Author

Oh, and please note: currently, only the first level of categories is shown in the navigation. E.g., if there are notes in the folders Test/A/, Test/B/ and Moin, then the list of categories in the navigation is Test, Moin.

@jancborchardt
Copy link
Member

Hmm, the 2-level navigation is a bit confusing, and not fully necessary:

  • recent is the default sorting
    -favorites should be sorted up top anyway
  • so the categories are the only thing left to display

I would prefer to see mockups or sketches, no matter how quick and dirty, before we rush into implementation. :) That way we can see how stuff works, and don't waste work on things which don't.

@korelstar
Copy link
Member Author

If you prefer to talk about mockups, then imagine that my implementation is a mockup ;-)

In order to make the list slim, we could remove the favorites item, of course. And note, that the search will be (re)moved, too (see #43). But we cannot remove the recent item, since otherwise, you cannot go back from a specific category to the whole list of notes. We can rename this item though.

However, the list of categories can be quite long (I'm using 11 first-level categories + uncategorized, in my personal notes). This would take much space from the screen (especially on mobile screens) and would require scrolling down in order to see the first notes items.

We would have to go with a second navigation then, like in the contacts app. In my personal opinion, this would be too distracting when writing notes. But if you prefer this, we could go this way.

I still think that my approach (showing categories on demand, using official Nextcloud design approaches) is best in giving access to categories and being not distracting when not using categories.

What's your proposal?

@korelstar korelstar force-pushed the category-navigation branch 5 times, most recently from 77ffef9 to a333a47 Compare August 18, 2018 08:26
@korelstar
Copy link
Member Author

korelstar commented Aug 18, 2018

updated screenshots

Default view:

... after clicking on "Categories" (collapsible):

... after clicking on the category "Receipes":

@jancborchardt Please have a look at the updated screenshots/mockups! I think this is a good solution, now!

@skjnldsv
Copy link
Member

Looks really great!

@korelstar korelstar force-pushed the category-navigation branch 2 times, most recently from 3106847 to 25c8849 Compare October 31, 2018 19:43
@korelstar korelstar added this to the 2.5.0 milestone Oct 31, 2018
@korelstar korelstar force-pushed the category-navigation branch from 25c8849 to 68e4fe8 Compare November 1, 2018 20:22
@korelstar korelstar force-pushed the category-navigation branch from 68e4fe8 to 4391ead Compare November 2, 2018 20:01
@korelstar korelstar changed the title [WiP] Category navigation Categories in navigation Nov 2, 2018
@korelstar korelstar merged commit f852e1b into master Nov 2, 2018
@korelstar korelstar deleted the category-navigation branch November 2, 2018 20:05
@stefan-niedermann
Copy link
Member

absolutely, looks great!

@BloodyIron
Copy link

How do you set categories in the new method? Drag and drop, or right click on the note, or what?

@BloodyIron
Copy link

Also, since this is the last item for the 2.5.0 milestone, any chance we could get this wrapped up and usable please? :DDD

@korelstar
Copy link
Member Author

See the screenshots in #228 for the current implementation of editing.

We have to do some testing and fixing the last bugs before releasing.

You can help in testing the latest state from master. Or you can increase the bounty on #8 in order to speed this up ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to the design or user experience enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants