Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display resp. edit the current note's category #228

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Conversation

korelstar
Copy link
Member

@korelstar korelstar commented Jul 24, 2018

This is kind of a proof of concept in order to prepare a new functionality for changing a note's category (see #8). Now, we can go into a discussion about design aspects, @nextcloud/designers and @jancborchardt . I suggest the following design for displaying resp. editing the category of the current note (cp. #218).

Default view for a uncategorized note

grafik

Clicking on the rename icon or on the category label =>

Editing the category

The list is build from the existing categories.
grafik

Confirm the change or focus another element =>

Changed category

grafik

@korelstar korelstar added the enhancement New feature or request label Jul 24, 2018
@stefan-niedermann
Copy link
Member

Personally i would prefer using folders like in the mail app or the news app for consistency over introducing a new style inside the edit view. This would also keep the focus on the text and the organisational part at the left sidebar.

@korelstar
Copy link
Member Author

How do you change the current item's folder in those apps? Is this done over the navigation, only?

My approach was to display the folder view in the navigation in order to show notes from specific folders/categories (a filter like in other Nextcloud apps, see #210) but to provide changeability using the status bar (this #228). I divided this into two issues/PRs for better focusing on specific aspects. Maybe, this wasn't a good idea.

Please give more details on your favorite solution. The best would be to provide a mock-up :-)

@korelstar korelstar changed the title Display resp. edit the current note's category [PoC] Display resp. edit the current note's category Aug 13, 2018
@korelstar korelstar mentioned this pull request Aug 18, 2018
8 tasks
@korelstar korelstar force-pushed the category-editor branch 2 times, most recently from d7e7342 to a13c396 Compare September 7, 2018 20:09
@marcelklehr
Copy link
Member

One alternative would be a drag and drop feature for moving notes around the folder hierarchy, another one would be to add another menu item to the note entry (should probably be collapsed into a three-dot menu in that case) for changing the category.

@korelstar korelstar force-pushed the category-editor branch 3 times, most recently from 504e869 to 7e959e5 Compare October 31, 2018 17:49
@korelstar korelstar changed the title [PoC] Display resp. edit the current note's category Display resp. edit the current note's category Oct 31, 2018
@korelstar
Copy link
Member Author

Let's start with this approach (otherwise we will never have any progress on this), the other part will be realized in #210.

@korelstar korelstar merged commit 6156d21 into master Oct 31, 2018
@korelstar korelstar deleted the category-editor branch October 31, 2018 18:25
@korelstar korelstar added this to the 2.5.0 milestone Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants