Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

techdebt(exceptions): Migrate to new exceptions #1882

Merged
merged 1 commit into from
Apr 15, 2024
Merged

techdebt(exceptions): Migrate to new exceptions #1882

merged 1 commit into from
Apr 15, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 11, 2024 •
edited
Loading

@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Apr 11, 2024
@nickvergessen nickvergessen mentioned this pull request Apr 11, 2024
Merged
4 tasks
@nickvergessen nickvergessen force-pushed the techdebt/44770/notification-exceptions branch from 3190c94 to 5b15ef1 Compare April 11, 2024 13:32
@nickvergessen nickvergessen self-assigned this Apr 11, 2024
@nickvergessen nickvergessen requested a review from come-nc April 11, 2024 13:33
come-nc
come-nc reviewed Apr 11, 2024
View reviewed changes
docs/notification-workflow.md Outdated Show resolved Hide resolved
lib/App.php Show resolved Hide resolved
lib/Notifier/AdminNotifications.php Show resolved Hide resolved
tests/Unit/AppTest.php

/** @var App */
protected $app;
protected Handler|MockObject $handler;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected Handler|MockObject $handler;
protected Handler&MockObject $handler;

If 8.0 was dropped.

@nickvergessen nickvergessen force-pushed the techdebt/44770/notification-exceptions branch from 5b15ef1 to f098a5d Compare April 12, 2024 07:30
@nickvergessen nickvergessen requested a review from come-nc April 12, 2024 07:31
@nickvergessen
techdebt(exceptions): Migrate to new exceptions
4bb3a73 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/44770/notification-exceptions branch from f098a5d to 4bb3a73 Compare April 15, 2024 07:47
@github-actions GitHub Actions
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8549 was 8200 (+4.25%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 3a46933 into master Apr 15, 2024
41 checks passed
@nickvergessen nickvergessen deleted the techdebt/44770/notification-exceptions branch April 15, 2024 07:55
@nickvergessen nickvergessen mentioned this pull request Apr 15, 2024
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

Assignees

@nickvergessen nickvergessen

Labels
None yet
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @come-nc