Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exceptions): Catch AlreadyProcessedException as well now #1892

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Apr 15, 2024

Follow up to #1882 to fix e.g.
https://github.com/nextcloud/spreed/actions/runs/8686992057/job/23819618008?pr=12110

{"Exception":"OCP\\Notification\\AlreadyProcessedException","Message":"Notification is processed already","Code":0,"Trace":[{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/apps\/spreed\/lib\/Notification\/Notifier.php","line":213,"function":"parseRemoteInvitationMessage","class":"OCA\\Talk\\Notification\\Notifier","type":"->","args":[["OC\\Notification\\Notification"],["OC\\L10N\\LazyL10N"]]},{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/lib\/private\/Notification\/Manager.php","line":355,"function":"prepare","class":"OCA\\Talk\\Notification\\Notifier","type":"->","args":[["OC\\Notification\\Notification"],"en"]},{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/apps\/notifications\/lib\/Controller\/EndpointController.php","line":118,"function":"prepare","class":"OC\\Notification\\Manager","type":"->","args":[["OC\\Notification\\Notification"],"en"]},{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":232,"function":"listNotifications","class":"OCA\\Notifications\\Controller\\EndpointController","type":"->","args":["v2"]},{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/lib\/private\/AppFramework\/Http\/Dispatcher.php","line":138,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Notifications\\Controller\\EndpointController"],"listNotifications"]},{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/lib\/private\/AppFramework\/App.php","line":184,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Notifications\\Controller\\EndpointController"],"listNotifications"]},{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/lib\/private\/Route\/Router.php","line":338,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Notifications\\Controller\\EndpointController","listNotifications",["OC\\AppFramework\\DependencyInjection\\DIContainer"],["v2","ocs.notifications.endpoint.listnotifications"]]},{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/ocs\/v1.php","line":66,"function":"match","class":"OC\\Route\\Router","type":"->","args":["\/ocsapp\/apps\/notifications\/api\/v2\/notifications"]},{"file":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/ocs\/v2.php","line":23,"args":["\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/ocs\/v1.php"],"function":"require_once"}],"File":"\/home\/runner\/actions-runner\/_work\/spreed\/spreed\/apps\/spreed\/lib\/Notification\/Notifier.php","Line":415,"message":"Notification is processed already","exception":{},"CustomMessage":"Notification is processed already"}

Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8548 was 8200 (+4.24%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the techdebt/44770/notification-exceptions branch from 951c387 to 12ac3d9 Compare April 15, 2024 10:22
Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 8549 was 8200 (+4.25%)
Please check your code again. If you added a new test this can be expected and the base value in tests/Integration/base-query-count.txt can be increased.

@nickvergessen nickvergessen merged commit 560e3e9 into master Apr 15, 2024
41 checks passed
@nickvergessen nickvergessen deleted the techdebt/44770/notification-exceptions branch April 15, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant