Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recursive folder previews #507

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Conversation

Mikescops
Copy link
Member

I'm not super fan of recursivity because it can lead to lot of computation, I suggest to lock it to one sub level only. I guess this would fit most of the people configuration, what do you think @skjnldsv ?

Closes #489

@Mikescops Mikescops requested a review from skjnldsv October 21, 2020 14:44
@Mikescops Mikescops self-assigned this Oct 21, 2020
@Mikescops Mikescops added 2. developing Work in progress bug Something isn't working labels Oct 21, 2020
@jancborchardt
Copy link
Member

One level seems good. Does that then also mean if you go down one level, the previews of the next sublevel will automatically start being generated already? (Which would be nice, as anticipation.)

@Mikescops
Copy link
Member Author

I will discuss with @skjnldsv about it.
But we don't start pre-generating inner folders

@Mikescops Mikescops force-pushed the feature/recursive-folder-previews branch from 011ed34 to 23d8df9 Compare October 23, 2020 14:59
@Mikescops
Copy link
Member Author

@skjnldsv let me know if you have a better idea on how to do it

@skjnldsv
Copy link
Member

Do as we do for folder? We fetch the first 4 images but one level deeper?

@Mikescops
Copy link
Member Author

I think it's good

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yveddt9

@skjnldsv
Copy link
Member

Please rebase and compile :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 28, 2020
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
@Mikescops Mikescops force-pushed the feature/recursive-folder-previews branch from 23d8df9 to 64fa03b Compare October 28, 2020 12:25
@Mikescops Mikescops merged commit 6a44991 into master Oct 28, 2020
@Mikescops Mikescops deleted the feature/recursive-folder-previews branch October 28, 2020 12:27
@BloodyIron
Copy link

I would prefer that recursivity matched the same behaviour that folder previews did before the major gallery overhaul several major versions ago. I actually used that preview recursivity to help me rapidly traverse many complex folder structures. So if this matches that previous style, I'm game for it. If not, I'd like to see that reivisited/implemented please.

@Mikescops
Copy link
Member Author

Not sure what you are talking about. Please provide examples, and I recommend trying current version before.

@BloodyIron
Copy link

I've tried the current and previous versions, I've reported this in another issue# and was directed here. I don't know how my explanation isn't clear...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show previews from subfolders if folder doesn't contains any images
4 participants