-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recursive folder previews #507
Conversation
One level seems good. Does that then also mean if you go down one level, the previews of the next sublevel will automatically start being generated already? (Which would be nice, as anticipation.) |
I will discuss with @skjnldsv about it. |
011ed34
to
23d8df9
Compare
@skjnldsv let me know if you have a better idea on how to do it |
Do as we do for folder? We fetch the first 4 images but one level deeper? |
I think it's good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and compile :) |
Signed-off-by: Corentin Mors <corentin.mors@dashlane.com>
23d8df9
to
64fa03b
Compare
I would prefer that recursivity matched the same behaviour that folder previews did before the major gallery overhaul several major versions ago. I actually used that preview recursivity to help me rapidly traverse many complex folder structures. So if this matches that previous style, I'm game for it. If not, I'd like to see that reivisited/implemented please. |
Not sure what you are talking about. Please provide examples, and I recommend trying current version before. |
I've tried the current and previous versions, I've reported this in another issue# and was directed here. I don't know how my explanation isn't clear... |
I'm not super fan of recursivity because it can lead to lot of computation, I suggest to lock it to one sub level only. I guess this would fit most of the people configuration, what do you think @skjnldsv ?
Closes #489