Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate sending invitations #1007

Merged
merged 7 commits into from
Jul 7, 2020
Merged

Separate sending invitations #1007

merged 7 commits into from
Jul 7, 2020

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Jul 5, 2020 •
edited
Loading

fix #935

Separated the process of adding shares in adding share and sending invitation.

  • Mails are now no more send direct with adding a share
  • Invitations get spooled and listed as unsent invitations
  • invitations can be sent and resend from the shares menu, if the share has an email address attached

grafik

To Do:

@dartcafe dartcafe mentioned this pull request Jul 5, 2020
Closed
@dartcafe dartcafe linked an issue Jul 5, 2020 that may be closed by this pull request
Invited users are sent emails without prompt #935
Closed
@dartcafe dartcafe self-assigned this Jul 5, 2020
@dartcafe dartcafe added this to the 1.5 milestone Jul 5, 2020
@dartcafe dartcafe requested a review from v1r0x July 6, 2020 07:33
@dartcafe dartcafe mentioned this pull request Jul 6, 2020
Closed
v1r0x
v1r0x previously approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@v1r0x v1r0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐧

@dartcafe dartcafe changed the base branch from rest-poc to master July 7, 2020 15:27
@dartcafe dartcafe dismissed v1r0x’s stale review July 7, 2020 15:27

The base branch was changed.

@dartcafe dartcafe merged commit 3f9ba10 into master Jul 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the seperate-sending-invitations branch July 7, 2020 16:07
@dartcafe dartcafe mentioned this pull request Aug 17, 2020
Merged
@dartcafe dartcafe mentioned this pull request Sep 21, 2020
Closed
@dartcafe dartcafe mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1r0x v1r0x v1r0x left review comments

Assignees

@dartcafe dartcafe

Labels
4. to release enhancement UX
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

Invited users are sent emails without prompt
2 participants
@dartcafe @v1r0x