Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding REST API #966

Merged
merged 21 commits into from
Jul 7, 2020
Merged

Adding REST API #966

merged 21 commits into from
Jul 7, 2020

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Jun 13, 2020 •
edited
Loading

added a REST API

  • extracted the BI from the Controllers to a new Services
  • new ApiControllers
  • started documentation

@dartcafe dartcafe marked this pull request as draft June 13, 2020 07:41
@dartcafe dartcafe linked an issue Jun 13, 2020 that may be closed by this pull request
Provide proper REST-API documentation #879
Closed
@dartcafe dartcafe mentioned this pull request Jun 13, 2020
Closed
@dartcafe dartcafe marked this pull request as ready for review June 20, 2020 13:31
@dartcafe dartcafe changed the title REST POC - initializing with comments Adding REST API Jun 20, 2020
stefan-niedermann
stefan-niedermann previously approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great documentation, this will be very helpful for every 3rd party app integration!

@dartcafe dartcafe added this to the 1.5 milestone Jun 27, 2020
@dartcafe
Copy link
Collaborator Author

@v1r0x Would be cool to have this PR reviewed before the other PRs.

This was referenced Jul 3, 2020
Merged
Merged
v1r0x
v1r0x requested changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@v1r0x v1r0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except my two small notes :)

@dartcafe
Copy link
Collaborator Author

dartcafe commented Jul 7, 2020

Merge OK after fixes?

@dartcafe dartcafe requested a review from v1r0x July 7, 2020 15:24
@dartcafe
Copy link
Collaborator Author

dartcafe commented Jul 7, 2020

BTW: Some URLs could be optimized too. Will do that in a PR together with the docs

@dartcafe
Copy link
Collaborator Author

dartcafe commented Jul 7, 2020 •
edited
Loading

Argh. I will merge this. Otherwise my testing instance needs a refresh due to db changes. Fixes should work. I will test this in the master branch afterwards. Sorry for overriding the final review...

@dartcafe dartcafe merged commit cf3e219 into master Jul 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the rest-poc branch July 7, 2020 15:33
@dartcafe dartcafe mentioned this pull request Sep 21, 2020
Closed
@dartcafe dartcafe mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefan-niedermann stefan-niedermann stefan-niedermann left review comments

@v1r0x v1r0x Awaiting requested review from v1r0x

Assignees
No one assigned
Labels
4. to release
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

Provide proper REST-API documentation
3 participants
@dartcafe @stefan-niedermann @v1r0x