Skip to content

fix: handle no HTTP_USER_AGENT information for $_SERVER when running through occ #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Sep 21, 2025
Merged

fix: handle no HTTP_USER_AGENT information for $_SERVER when running through occ #637

nickvergessen merged 1 commit into from
Sep 21, 2025

Conversation

@tcitworld
Copy link
Member

@tcitworld tcitworld commented Sep 21, 2025 •
edited
Loading

console.php loads the provider to collect with  IRequest even though we have no user-agent information, so let's fallback to an empty string.

Similar issue at nextcloud/server#55241

An unhandled exception has been thrown:
ErrorException: Undefined array key "HTTP_USER_AGENT" in server/apps/profiler/lib/DataCollector/HttpDataCollector.php:31
Stack trace:
#0 server/apps/profiler/lib/DataCollector/HttpDataCollector.php(31): OCA\Files\Command\ScanAppData->exceptionErrorHandler()
#1 server/lib/private/Profiler/Profiler.php(69): OCA\Profiler\DataCollector\HttpDataCollector->collect()
#2 server/console.php(98): OC\Profiler\Profiler->collect()
#3 server/occ(33): require_once('...')
#4 {main}%

@tcitworld
fix: handle no HTTP_USER_AGENT information for $_SERVER when running …
b753f6a 
…through occ

console.php loads the provider to collect with IRequest even though we have no user-agent
information, so let's fallback to an empty string

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added bug Something isn't working 3. to review labels Sep 21, 2025
@tcitworld tcitworld requested a review from come-nc September 21, 2025 16:09
@tcitworld tcitworld mentioned this pull request Sep 21, 2025
Merged
4 tasks
@nickvergessen nickvergessen merged commit 847d06c into master Sep 21, 2025
21 checks passed
@nickvergessen nickvergessen deleted the handle-no-user-agent branch September 21, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@come-nc come-nc Awaiting requested review from come-nc

Assignees

No one assigned

Labels

3. to review bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tcitworld @nickvergessen