Skip to content

Conversation

@tcitworld
Copy link
Member

Due to the profiler app loading HttpDataCollector when running occ.

This won't change behavior, fallback value is still 'HTTP/1.1' (but the error of missing SERVER_PROTOCOL won't be shown though).

Similar issue at nextcloud/profiler#637

An unhandled exception has been thrown:
ErrorException: Undefined array key "SERVER_PROTOCOL" in server/lib/private/AppFramework/Http/Request.php:679
Stack trace:
#0 server/lib/private/AppFramework/Http/Request.php(679): OCA\Files\Command\ScanAppData->exceptionErrorHandler()
#1 server/apps/profiler/lib/DataCollector/HttpDataCollector.php(30): OC\AppFramework\Http\Request->getHttpProtocol()
#2 server/lib/private/Profiler/Profiler.php(69): OCA\Profiler\DataCollector\HttpDataCollector->collect()
#3 server/console.php(98): OC\Profiler\Profiler->collect()
#4 server/occ(33): require_once('...')
#5 {main}%        

Checklist

…TOCOL'] if called from occ

Due to the profiler app loading HttpDataCollector when running occ.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld merged commit ded505a into master Sep 22, 2025
210 of 212 checks passed
@tcitworld tcitworld deleted the fix-request-protocol-empty-on-occ branch September 22, 2025 08:33
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
@nextcloud-bot nextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants