Enhancements for ui regression testing

[juliusknorr]

Summary of what is left to improve the ui regression testing that was merged with #8357

• Fix possible failure due to scroll on click behavior on login page
• Fix possible failure due to changing time in personal settings
• Fix possible failure of file-unshare test
• Automatically comment test status on the pull request
• installation timeout:

   {
     "title": "runs",
     "fullTitle": "install runs",
     "duration": 90794,
     "currentRetry": 0,
     "err": {
       "stack": "Error: Execution context was destroyed, most likely because of a navigation.\n    at rewriteError (node_modules/puppeteer/lib/ExecutionContext.js:135:15)\n    at <anonymous>\n    at process._tickCallback (internal/process/next_tick.js:188:7)",
       "message": "Execution context was destroyed, most likely because of a navigation."
     }
   }
  

• Comment on github issues about failures Try out danger.js for ui-regression tests #10507
• Fix URL in "The result can be found at" message

[nextcloud-bot]

GitMate.io thinks possibly related issues are #8258 (Visual regression testing), #9816 (enhancement: merging accounts), #2630 (Sharing: review node fix + add regression test), #10258 (files dates ( enhancement )), and #4498 (Acceptance test).

[MorrisJobke]

Let's move this to 16 - it's an ongoing effort anyways and not bound to a milestone.

[MorrisJobke]

@juliushaertl 🏓

[juliusknorr]

On my list, but let me remove the milestone, since this is nothing that is actually related to a release.

[szaimen]

Are some of those points already fixed or is this issue still valid?

[juliusknorr]

The initial attempt of UI testing was dropped as puppeteer was causing too much issues and we mostly use cypress these days in apps, so that would be covered in #7607 for the server. Closing in favor of that one.