-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace PhantomJS with Cypress #7607
Comments
cc @nextcloud/javascript |
Yes, PhantomJS was abandoned, sooner or later it needs to re replaced. Firefox can also run in headless mode, whether it is installable on a headless machine idk. In general, yes, we need to move somewhere. |
See #8357 and #8258 - cc @juliushaertl |
karma has a chrome headless launcher, so it should not be to hard to switch. Line 301 in a18a853
|
I recently stumbled across cypress, which is a combination of test framework/assertion library with mocking support that uses chrome headless and seems they will support firefox in the future as well: cypress-io/cypress#1096 Right now I'm trying to use it for some testing on the deck app, and until now I'm really impressed how nice things work there. Maybe it is worth to consider this for the server in some parts as well. |
Since we use cypress for the vue-components now as well, I guess this will be the way to go. |
We shoud also replace our acceptance tests with cypress :) |
Moving to headless chrome as a first step in #24872 |
PhantomJS seems basically gone from server. Only references of consequence across the entire org that I see are:
|
Closing then |
I just stumbled upon this blogpost from Gitlab and was wondering if this will become necessary here as well: https://about.gitlab.com/2017/12/19/moving-to-headless-chrome/
Looks like PhantomJS will not be developed further https://groups.google.com/forum/#!topic/phantomjs/9aI5d-LDuNE and if I am not wrong it is used here as well. So in the long run, it might need to be replaced with headless chrome?!
PS: I am not really familiar with PhantomJS, so please excuse if I got something wrong here.
The text was updated successfully, but these errors were encountered: