Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PhantomJS with Cypress #7607

Closed
raimund-schluessler opened this issue Dec 22, 2017 · 10 comments
Closed

Replace PhantomJS with Cypress #7607

raimund-schluessler opened this issue Dec 22, 2017 · 10 comments
Labels
technical debt tests Related to tests

Comments

@raimund-schluessler
Copy link
Member

I just stumbled upon this blogpost from Gitlab and was wondering if this will become necessary here as well: https://about.gitlab.com/2017/12/19/moving-to-headless-chrome/

Looks like PhantomJS will not be developed further https://groups.google.com/forum/#!topic/phantomjs/9aI5d-LDuNE and if I am not wrong it is used here as well. So in the long run, it might need to be replaced with headless chrome?!

PS: I am not really familiar with PhantomJS, so please excuse if I got something wrong here.

@MorrisJobke
Copy link
Member

cc @nextcloud/javascript

@blizzz
Copy link
Member

blizzz commented Dec 22, 2017

Yes, PhantomJS was abandoned, sooner or later it needs to re replaced. Firefox can also run in headless mode, whether it is installable on a headless machine idk. In general, yes, we need to move somewhere.

@MorrisJobke
Copy link
Member

See #8357 and #8258 - cc @juliushaertl

@juliusknorr
Copy link
Member

karma has a chrome headless launcher, so it should not be to hard to switch.

browsers: ['PhantomJS'],

@juliusknorr juliusknorr added the 1. to develop Accepted and waiting to be taken care of label Jun 1, 2018
@juliusknorr
Copy link
Member

juliusknorr commented Jun 18, 2018

I recently stumbled across cypress, which is a combination of test framework/assertion library with mocking support that uses chrome headless and seems they will support firefox in the future as well: cypress-io/cypress#1096

Right now I'm trying to use it for some testing on the deck app, and until now I'm really impressed how nice things work there. Maybe it is worth to consider this for the server in some parts as well.

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jul 19, 2018
@skjnldsv skjnldsv removed stale Ticket or PR with no recent activity labels Jun 12, 2019
@raimund-schluessler
Copy link
Member Author

Since we use cypress for the vue-components now as well, I guess this will be the way to go.

@raimund-schluessler raimund-schluessler changed the title Replace PhantomJS with headless Chrome Replace PhantomJS with Cypress Sep 14, 2020
@skjnldsv
Copy link
Member

We shoud also replace our acceptance tests with cypress :)

@juliusknorr
Copy link
Member

Moving to headless chrome as a first step in #24872

@joshtrichards
Copy link
Member

PhantomJS seems basically gone from server. Only references of consequence across the entire org that I see are:

  • docker-ci Dockerfile (an environment variable?)
  • mail
  • integration_whiteboard
  • gallery (archived)

@joshtrichards joshtrichards added the tests Related to tests label Aug 27, 2023
@skjnldsv
Copy link
Member

Closing then

@skjnldsv skjnldsv removed the 1. to develop Accepted and waiting to be taken care of label Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt tests Related to tests
Projects
None yet
Development

No branches or pull requests

7 participants