Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual regression testing #8258

Closed
juliusknorr opened this issue Feb 8, 2018 · 5 comments
Closed

Visual regression testing #8258

juliusknorr opened this issue Feb 8, 2018 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement

Comments

@juliusknorr
Copy link
Member

I had a look about what we can do to add some sort of automated visual regression testing so that changes that break the layout somehow can be spotted a bit easier.

Wraith (http://bbc-news.github.io/wraith/) looks like a pretty nice tool for that, and first tests worked fine so far. It would be nice to have some basic diff testing for every pull request and reports there if any of those screenshots differ to much.

Here is an example of the output for the login page, that would have spotted a regression like in #8035
screenshot-2018-2-8 screenshot

Any toughts about that are welcome @nextcloud/designers @nextcloud/qa Also @danxuliu since you seemed to be the acceptance testing hero in the past 😉

@juliusknorr juliusknorr added enhancement 1. to develop Accepted and waiting to be taken care of labels Feb 8, 2018
@juliusknorr juliusknorr self-assigned this Feb 8, 2018
@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2018

Amazing, I was setting this up not long ago, but with PhantomCss! :D
Yes, definitely, but this should not be a merge breaker. Only a big warning :)

@rullzer
Copy link
Member

rullzer commented Feb 8, 2018

yes please!

@MorrisJobke
Copy link
Member

I just stumbled today over this one here: https://meowni.ca/posts/2017-puppeteer-tests/

@juliusknorr
Copy link
Member Author

@MorrisJobke I'll have a look at that as well.

@juliusknorr juliusknorr removed their assignment May 13, 2018
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@juliusknorr
Copy link
Member Author

juliusknorr commented Jul 30, 2018

Added with #8357

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement
Projects
None yet
Development

No branches or pull requests

5 participants