Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contacts menu uses javascript eval #11029

Closed
rullzer opened this issue Sep 3, 2018 · 2 comments
Closed

Contacts menu uses javascript eval #11029

rullzer opened this issue Sep 3, 2018 · 2 comments
Assignees
@skjnldsv
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: contacts menu
Milestone
Nextcloud 15

Comments

@rullzer
Copy link
Member

rullzer commented Sep 3, 2018

For https://github.com/orgs/nextcloud/projects/18

The contacts menu still uses handlebars and compiles the templates on the fly. This means that it uses unsafe eval and prevents a stricter CSP
@rullzer
Copy link
Member Author

rullzer commented Sep 3, 2018

@skjnldsv could you have a look as to what has to be done how to set it (for compilation etc)?

@rullzer rullzer added enhancement 1. to develop Accepted and waiting to be taken care of labels Sep 3, 2018
@rullzer rullzer added this to the Nextcloud 15 milestone Sep 3, 2018
@skjnldsv skjnldsv self-assigned this Sep 3, 2018
@nextcloud-bot

This comment has been minimized.

Sign in to view
This was referenced Sep 3, 2018
Closed
Closed
Closed
Closed
rullzer added a commit that referenced this issue Sep 27, 2018
@rullzer
Compile contactmenu handlebars templates
ec6a342 
Fixes #11029
For https://github.com/orgs/nextcloud/projects/18

Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer mentioned this issue Sep 27, 2018
Merged
rullzer added a commit that referenced this issue Sep 27, 2018
@rullzer
Compile contactmenu handlebars templates
c9e93b8 
Fixes #11029
For https://github.com/orgs/nextcloud/projects/18

Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: contacts menu
Projects
None yet
Milestone
Nextcloud 15
Development

No branches or pull requests
3 participants
@rullzer @skjnldsv @nextcloud-bot