Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile contactmenu handlebars templates #11414

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Sep 27, 2018

Fixes #11029
For https://github.com/orgs/nextcloud/projects/18

Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes #11029
For https://github.com/orgs/nextcloud/projects/18

Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the csp/11029/contacts_menu_compiled_handlebars branch from 9d962aa to c9e93b8 Compare September 27, 2018 18:34
@danxuliu
Copy link
Member

For future reference, to know how to update the templates see this note in filesummary.js (maybe it would be a good idea to include the note in contactsmenu.js too? Although if more and more templates are compiled we would end having the same note everywhere).

@ChristophWurst
Copy link
Member

For future reference, to know how to update the templates see this note in filesummary.js (maybe it would be a good idea to include the note in contactsmenu.js too? Although if more and more templates are compiled we would end having the same note everywhere).

As discussed in private IRC with @rullzer, I would suggest to add a script that builds all Handlebars templates at once. That will make it easier for devs and also enable us to easily check if they are up to date on CI.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works 👍

@MorrisJobke MorrisJobke merged commit e204700 into master Sep 28, 2018
@MorrisJobke MorrisJobke deleted the csp/11029/contacts_menu_compiled_handlebars branch September 28, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants