-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile contactmenu handlebars templates #11414
Compile contactmenu handlebars templates #11414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some extra '
in the resulting HTML that need to be removed (see https://github.com/nextcloud/server/pull/11414/files#diff-c507f8bb125161aa4ce14d65829a1399R1 or https://github.com/nextcloud/server/pull/11414/files#diff-ed39afd2b2498db3bfb8542af14024c8R2).
Fixes #11029 For https://github.com/orgs/nextcloud/projects/18 Ship the compiled handlebars templates. This makes it possible to have a scricter CSP. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
9d962aa
to
c9e93b8
Compare
For future reference, to know how to update the templates see this note in |
As discussed in private IRC with @rullzer, I would suggest to add a script that builds all Handlebars templates at once. That will make it easier for devs and also enable us to easily check if they are up to date on CI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works 👍
Fixes #11029
For https://github.com/orgs/nextcloud/projects/18
Ship the compiled handlebars templates. This makes it possible to have a
scricter CSP.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl