Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Nextcloud 17 polishing list! #16076

Closed
49 of 77 tasks
jancborchardt opened this issue Jun 25, 2019 · 13 comments
Closed
49 of 77 tasks

✨ Nextcloud 17 polishing list! #16076

jancborchardt opened this issue Jun 25, 2019 · 13 comments
Labels
2. developing Work in progress bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. help wanted high papercut Annoying recurring issue with possibly simple fix.

Comments

@jancborchardt
Copy link
Member

jancborchardt commented Jun 25, 2019

As usual, we test the daily zip file to find details for polishing. 🎉

Everyone should go over the issues and see where they can help out! 😊 Add your handle if you work on it, or relevant issues or pull requests.

Bold issues are especially important and should be fixed for the release!

🏗 Pre-installation

  • Zip file is huge!
    • Because of .map files? – they are not that big
    • viewer ships cypress (36.4MB): Should be removed in tomorrows daily
    • 3rdparty/aws/aws-sdk-php/src/data possibly not necessary (12.2MB) too risky, might be in use
  • Change name of "Nextcloud.mp4" to "Nextcloud intro.mp4" to fix the strange Viewer issue which accomodates for iOS live images → pull request at Rename video to fix live image clash example-files#5

👩‍🏭 Installation

  • Finish button not visible on some screens – possibly sticky, or make warning wider
  • Missing loading feedback on installation, should have a spinner – it’s there, Safari just stops rendering
  • Security warning is not greyed out
  • Whitescreen on installation, no feedback was caused by fatal PHP error caused by the support app interface, fixed by @juliushaertl

🧙 First run wizard

  • First run wizard should have different viewer background opacity (less dark) @juliushaertl
  • Scrollbar shows @juliushaertl
  • Content should fit into box @juliushaertl
  • Container shouldn’t need to resize between slides, adjust content, fix height and width @juliushaertl
  • Button style difference too harsh, prev button should have slight white-ish background

📁 Files

🍔 Sidebar

  • Share link should not open menu automatically
  • Copy link directly when sharing with tooltip feedback "Share created & link copied"
  • ~Share link flow revisit → 18~
  • Fix outdated comment icon → pull request at adding toggle password to be able to see it when login #15881
  • Add to project second row has too much line height (test if it flows into 2 lines)

👥 Sharing

📄 PDF viewer

🔮 Recommendations

🖼 Viewer

🏷 Tags

  • If there’s tags, show autocomplete dropdown directly on opening the "Tags" section. That is, autofocus the field so the dropdown shows.

⚡ Activity

  • .mp4 filetype uses non-existing "video-mp4.svg" as mimetype icon, but we only have "video.svg" and should use that Only return link to themed icon if file exists #16095
  • Activity settings: Instead of "Stream" use setting for "Push notifications". Use icons for Mail and Phone. Just show everything in stream. 2-4 weeks task
  • If Calendar app is not installed, show "Install Calendar app" with link to apps mgmt in emptycontent view of "Calendar" in Activity stream
  • Creation "+" icon looks interactive, bit confusing. Maybe different icon, maybe not use color

🖼 Gallery

🔎 Search

  • Show "Results from other folders" as a bigger header before the other results
  • Fix left-alignment of other results (move slightly to right to be same position as list view)

🔔 Notifications

  • Put timestamp below message instead of on top right to not conflict with close x

👥 Contacts menu

⚙ Settings personal

  • Too much vertical whitespace between entries in "Personal settings"
  • Mobile & desktop settings: Check over wording of "Server address"
  • Accessibility settings: prevent checking both High contrast and Dark theme
  • Remove "(beta)" label from Dark theme?
  • Federated Cloud: Nice image or illustration and more info about what it does, compare https://nextcloud.com/federation/
  • Privacy: Add the icons of the user data manifesto
  • Privacy: Put country picker above world map, and directly highlight country when choosing
  • Privacy: Country highlight should be primary theming color instead of red Use primary theming color for country selection privacy#179

⚙ Settings admin

🛠 Apps management

👥 User management

❓ Help

  • Add icons to the left sidebar
@jancborchardt jancborchardt added this to the Nextcloud 17 milestone Jun 25, 2019
@jancborchardt jancborchardt added the papercut Annoying recurring issue with possibly simple fix. label Jun 25, 2019
@jancborchardt
Copy link
Member Author

cc @nextcloud/designers @nextcloud/vue and everyone really – if you want to pick up anything from this, you’re most welcome! :)

@enoch85

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@enoch85

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

@ChristophWurst

This comment has been minimized.

GretaD added a commit that referenced this issue Jul 12, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
GretaD added a commit that referenced this issue Jul 16, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
GretaD added a commit that referenced this issue Jul 17, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
GretaD added a commit that referenced this issue Jul 17, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
@MorrisJobke MorrisJobke mentioned this issue Jul 17, 2019
28 tasks
rullzer pushed a commit that referenced this issue Jul 18, 2019
Signed-off-by: Greta Doci <gretadoci@gmail.com>
MorrisJobke added a commit that referenced this issue Jul 18, 2019
…rder-top

 Add border-top to settings menu when its open ref #16076
MorrisJobke added a commit that referenced this issue Jul 18, 2019
@Thatoo

This comment has been minimized.

@skjnldsv

This comment has been minimized.

@kesselb

This comment has been minimized.

@sunjam

This comment has been minimized.

@jancborchardt

This comment has been minimized.

@jancborchardt
Copy link
Member Author

It’s been a few months since the polishing review and most of the issues were fixed. :) So as per usual, we’re going to close the issue and open a new one at the next polishing review.

For any leftover issues which you think should be fixed, please open a separate issue or – even better – a pull request to fix them. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug good first issue Small tasks with clear documentation about how and in which place you need to fix things in. help wanted high papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants