Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1px jump when selecting multi table entries #16475

Merged
merged 1 commit into from
Jul 22, 2019
Merged

Fix 1px jump when selecting multi table entries #16475

merged 1 commit into from
Jul 22, 2019

Conversation

weeman1337
Copy link
Member

I just changed the CSS to keep the header border if items are selected.

select_some
select_all

#16076

@weeman1337
Fix 1px jump when selecting multi table entries
68049f1 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337 weeman1337 added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Jul 20, 2019
@weeman1337 weeman1337 added this to the Nextcloud 17 milestone Jul 20, 2019
@jancborchardt jancborchardt mentioned this pull request Jul 20, 2019
Closed
77 tasks
MorrisJobke
MorrisJobke approved these changes Jul 22, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 22, 2019
@skjnldsv skjnldsv merged commit b6376b7 into master Jul 22, 2019
@skjnldsv skjnldsv deleted the bugfix/16076/select-1px branch July 22, 2019 10:29
jancborchardt
jancborchardt reviewed Jul 22, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.
4 participants
@weeman1337 @MorrisJobke @jancborchardt @skjnldsv