Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow frontend polishing #18191

Closed
juliusknorr opened this issue Dec 2, 2019 · 3 comments
Closed

Flow frontend polishing #18191

juliusknorr opened this issue Dec 2, 2019 · 3 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc.

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Dec 2, 2019

  • The icons in the action boxes can be a bit closer to the text below. Should have same distance from the text as the button below More workflow frontend polishing #17997 (comment)
  • when a second row of operations is shown, don't hide its elements (the + is visible after all anyway)
  • The link to the apps is not created correctly when running in a subfolder (the subfolder is cut away), but that was already the case before. All changed things shiny :)
@juliusknorr juliusknorr added bug design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of labels Dec 2, 2019
@juliusknorr juliusknorr self-assigned this Dec 2, 2019
@juliusknorr
Copy link
Member Author

juliusknorr commented Dec 23, 2019

@jancborchardt Do you remember what the following was exactly about?

when a second row of operations is shown, don't hide its elements (the + is visible after all anyway)

@jancborchardt
Copy link
Member

@jancborchardt Do you remember what the following was exactly about?

when a second row of operations is shown, don't hide its elements (the + is visible after all anyway)

This is feedback from @blizzz actually :) #17997 (review)

@blizzz
Copy link
Member

blizzz commented Jan 8, 2020

This was about the operation chooser on the top. We would show a second row, but only the first item of it. But things have changed since. It looks OK for admins (with the extra tile that points you to the app store), but for users when there are four ops (and four fit into a row), only three are shown:

Screenshot_20200108_170314

Screenshot_20200108_170344

Minor issue. In smaller windows, it's accurate when only 3 are show.

Oh, back to Admin settings with a small window.

Collapsed:

Screenshot_20200108_170618

Expanded:

Screenshot_20200108_170637

All in all it's fiddly, but overall OK, and not really in the way or anything. Let's close.

@blizzz blizzz closed this as completed Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc.
Projects
None yet
Development

No branches or pull requests

3 participants