Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining flow frontend polishing #18484

Merged
merged 4 commits into from
Dec 19, 2019
Merged

Remaining flow frontend polishing #18484

merged 4 commits into from
Dec 19, 2019

Conversation

juliusknorr
Copy link
Member

  • Checks will automatically pick up is/matches depending if the value is a regex or not. e.g. when choosing "Images" as mime type, the checker will only work when the operator is "matches", not "is"
  • Add flow icon for app store category …
  • Fix action listing alignment and show more button

@juliusknorr juliusknorr added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: workflows labels Dec 19, 2019
@juliusknorr juliusknorr added this to the Nextcloud 18 milestone Dec 19, 2019
skjnldsv
skjnldsv approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ChristophWurst
ChristophWurst approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 19, 2019
@ChristophWurst
Copy link
Member

needs a rebase

@ChristophWurst
Copy link
Member

(and run the lint fix just in case)

@juliusknorr
Add flow icon for app store category
46931c9 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix action listing alignment
15b64c6 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Set operation mode according to the mime type value
0cdcdb3 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump bundles
edbf35d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/flow-plish branch from a74fcd1 to edbf35d Compare December 19, 2019 14:23
blizzz
blizzz approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link to the apps is not created correctly when running in a subfolder (the subfolder is cut away), but that was already the case before. All changed things shiny :)

@skjnldsv skjnldsv merged commit 899021f into master Dec 19, 2019
@skjnldsv skjnldsv deleted the bugfix/noid/flow-plish branch December 19, 2019 18:15
@juliusknorr
Copy link
Member Author

@blizzz Actually there was another polishing issue i forgot so I'm adding your comment to #18191 for the next batch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@blizzz blizzz blizzz approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: workflows
Projects
None yet
Milestone
Nextcloud 18.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusknorr @ChristophWurst @blizzz @skjnldsv