-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various flow related fixes #18547
Various flow related fixes #18547
Conversation
juliusknorr
commented
Dec 23, 2019
•
edited
Loading
edited
- Allow selecting other event types (fix Flow: fail to pick a third party entity event #18510)
- Fix app store link and hide it for users (fix Flow: Browse the app store is not possible for users #18495 Flow: (Admin) More flows broken with Nextcloud installation in sub directory #18500)
- Flow: Invalid rule will emit a log message Flow: Invalid rule will emit a log message #18496
- Flow frontend polishing #18191
- The icons in the action boxes can be a bit closer to the text below. Should have same distance from the text as the button below More workflow frontend polishing #17997 (comment)
- The link to the apps is not created correctly when running in a subfolder
10e2777
to
397da93
Compare
397da93
to
634e1c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always see "The configuration is invalid" even if it is not (existing and new rules). Despite saving works.
Ah indeed, seems to only occur with multiple checks. Fix pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works now!
Just, an other thing: unconditional flows (without a check) were OK before. Rejecting them could potentially break older once… Not that I have an idea where they would be useful. That might come back to us. Otherwise, +1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix app store link and hide it for users (fix Flow: Browse the app store is not possible for users #18495 Flow: (Admin) More flows broken with Nextcloud installation in sub directory #18500)
- Flow: Invalid rule will emit a log message Flow: Invalid rule will emit a log message #18496
👍
Yes, I was thinking the same, but I also could not think of a rule that would make sense without any check. |
Config switch :p Okay. Existing ones should run, but not be modifyable anymore. Let's just be sure to document it in the release notes. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
d6aa675
to
b2ba561
Compare