[BITV] "Settings" and "New" action names must be distinct

[PVince81]

The term "Settings" and "New" are used in various places and is not distinct enough.
Accessibility requires more distinct names so that one can reach those places for example by getting a listing of links present in the page.

• "Settings"
  • Settings in the bottom left on the files app: always state the app name, see [BITV] "Settings" and "New" action names must be distinct #32350 (comment)
  • remove aria-label from div of the settings menu not needed
  • keep "Settings menu" aria-label itself in the nav (test that it's detectable/reachable when tabbing on the settings menu item when closed)
  • Settings menu entry on the top right: stay generic as they are in a menu => no-op
• "New"
  • "New" in the files app
  • "New" in the gallery app

@jancborchardt @nimishavijay

[PVince81]

@jancborchardt @nimishavijay please help to find the appropriate wordings for the accessible names and whether we also want to rename the label to something more explicit

[Pytal]

These would be aria-label or .visually-hidden? So the display text would remain unchanged?

[PVince81]

from the accessibility review it's not clear if it's the accessible name (aria-label) or whether the real text itself is a problem

in an accessibility context I know that screen readers have a feature that allows you to list all links within a page, so if the accessible names are all the same a user would not know which one is which.

so I guess at least the accessible names (aria-label for links and visually-hidden for icons) must be adjusted

[nimishavijay]

So I checked Google and MS, and there is never mention of more than one "Settings" per page, and it's settings of the current app, which is placed in the top right corner. The account related settings are labelled as "Manage your account" or something similar.

For "Settings"

• to start with we could change the visual label of the bottom left settings to "[app name] settings" for eg. "Talk settings" or "Mail settings"
• The top right settings could be called "Account settings" or "Nextcloud settings". This should clear up confusion in the list of links also

For "New":

• We could change add a visual label that says "New", but just a IMO plus icon is universally recognised as add/new, so I wouldn't mind if visually there was no change. Any preferences @jancborchardt ?
• The aria-label or visually-hidden label can be "Create or upload files" in Files and "Upload media" in Gallery

[PVince81]

@Pytal note: when touching the "+" button please also fix it in the file picker as this was reported inconsistent in https://github.com/nextcloud-gmbh/server/issues/461

[Pytal]

As per https://github.com/nextcloud-gmbh/server/issues/461#issuecomment-1188086173 and their explanation from https://nextcloud-accessibility-full-april2022.netlify.app/problems/3-2-4-consistent-identification/

Remember that consistent naming doesn’t necessarily mean identical naming. If these buttons add different things they could be named “Add folder”, “Add document” for instance, at it would be consistent since their function of adding something would be consistently explained.

Everything seems in order @PVince81

[jancborchardt]

Agree with @nimishavijay's proposal

• Bottom left settings could always state the app name like "Talk settings", " Files settings" etc
• Top right settings could stay generic as they are in a menu
• The "+" button could use a label "New". This is e.g. also how Google Drive names it
• The button could additionally get a detailed aria-label like "Create new file or folder"?

[PVince81]

@Pytal cool if the button is fixed already

[PVince81]

• files app: change to "Files settings": Rename files settings on the bottom left #33306
• talk app: already says "Talk settings"
• activity app. "Settings" => "Activity Settings": Rename settings to activity settings on bottom left activity#853
• calendar app: "Settings and import" => "Calendar settings": Rename settings to Calendar Settings calendar#4391
• contacts app: "Settings" => "Contacts settings": Rename settings to "Contacts settings" contacts#2861
• tasks app: "Settings" => "Tasks settings": Rename settings to tasks settings tasks#2053
• deck app: "Settings" => "Deck settings": Rename settings to deck settings deck#3928
• mail app: "Settings" => "Mail settings": Rename settings to mail settings mail#6936
• photos: "Settings" => "Photos settings": Rename settings to photos settings photos#1139
• collectives: "Settings" => "Collectives settings" https://gitlab.com/collectivecloud/collectives/-/merge_requests/587
• dashboard: N/A
• forms: N/A

[PVince81]

regarding the top-right menu, I see that the aria-label is kind of duplicate:

I've updated the top post to remove the aria-label on the div and keep the one on nav, but one needs to test that it actually works correctly that way

[PVince81]

@jancborchardt for calendar I guess we can keep calling it "Settings & import" ? or should we rename to "Calendar settings" still to avoid less duplication and confusion ? But that label would make it less clear that "import" is there too. I suppose it's ok.

[jancborchardt]

@jancborchardt for calendar I guess we can keep calling it "Settings & import" ? or should we rename to "Calendar settings" still to avoid less duplication and confusion ? But that label would make it less clear that "import" is there too. I suppose it's ok.

Yeah – I commented on the PR, I think it's ok to change it, we should probably call out import in another way too like e.g. via the "+ New calendar" menu (cause you might want to import a whole new calendar), as well as the "New event / New task" menu. cc @miaulalala

[PVince81]

@juliushaertl can you take care of the collectives one ? #32350 (comment)

[juliusknorr]

Created a merge request at https://gitlab.com/collectivecloud/collectives/-/merge_requests/587 and added to the list

[PVince81]

@miaulalala can you take care of the mail app one ?

[miaulalala]

Message button already has a button text "New Message", is that sufficient?

Settings will follow in a minute.

[miaulalala]

nextcloud/mail#6936

[PVince81]

#33271 merged for a better label for the "New" menu

[PVince81]

• another PR to remove an extra occurrence: Transfer aria-label from nav settings menu to settings menu icon-button #33385