Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename files settings on the bottom left #33306

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Rename files settings on the bottom left #33306

merged 2 commits into from
Jul 22, 2022

Conversation

PVince81
Copy link
Member

Part of #32350

image

@PVince81
Rename files settings on the bottom left
61e4095 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 added 3. to review Waiting for reviews accessibility labels Jul 21, 2022
@PVince81 PVince81 self-assigned this Jul 21, 2022
@PVince81 PVince81 mentioned this pull request Jul 21, 2022
Closed
7 tasks
@PVince81 @jancborchardt
Change casing of settings label
2abf426 
Co-authored-by: Jan C. Borchardt <hey@jancborchardt.net>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 requested a review from jancborchardt July 21, 2022 13:55
@Pytal
Copy link
Member

Pytal commented Jul 21, 2022

CI failure seems related to this

server/tests/acceptance/features/bootstrap/SettingsMenuContext.php

Line 143 in 6c42874

$this->actor->find(self::menuItemFor('Settings'), 2)->click();

@PVince81 PVince81 merged commit 6f0ae0b into master Jul 22, 2022
@PVince81 PVince81 deleted the bugfix/32350/rename-files-settings branch July 22, 2022 09:44
@PVince81
Copy link
Member Author

I'll push a follow up PR

@PVince81
Copy link
Member Author

PVince81 commented Jul 22, 2022 •
edited
Loading

@Pytal I checked the related code and it all looks related to the top right menu, not the bottom left one. weird

@PVince81
Copy link
Member Author

@Pytal this is the actual issue: Nextcloud test server could not be started (Exception)

it's just a coincidence that the test scenario contains a reference to settings, and here it means the settings page from the top right menu

@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimishavijay nimishavijay nimishavijay approved these changes

@Pytal Pytal Pytal approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@PVince81 PVince81

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @Pytal @jancborchardt @nimishavijay