Header icons need to invert to black/dark on specific preset background images (like the Dashboard does)

[jancborchardt]

The Dashboard already does this correctly, and as discussed with @juliushaertl we should use the same logic for the other pages. Specifically, this applies to these 4 backgrounds:

• bernie-cetonia-aurata-take-off-composition.jpg
• lali-masriera-yellow-bricks.jpg
• rawpixel-pink-tapioca-bubbles.jpg
• tommy-chau-lion-rock-hill.jpg

The logic seems to be with the --primary-invert-if-bright variable as far as I can see.

Correct in Dashboard – I would additionally say that we need to invert the logo as well (only if it is our default Nextcloud logo though) cc @karlitschek

Needs to be adjusted in the other apps. I assume with Julius’ move of the header to Vue this might be easier?

[szaimen]

@CarlSchwan could you maybe also have a fast look into this? I think it is pretty bad...

[skjnldsv]

Once #34272 is done, we can easily adjust --primary-invert-if-bright accordingly
I can handle it if no one is diving into this. :)

cc @Pytal

[Pytal]

Preset colors of shipped backgrounds are used as primary in #34298

If this touches the same code then it can be handled by @skjnldsv after the above PR

[skjnldsv]

Fixed with #34298

[Pytal]

Fixed on dashboard and appearance pages but not globally like on the files page

The --primary-invert-if-bright variable needs to be adjusted then @skjnldsv?

[skjnldsv]

Isn't the primary-invert-if-bright already using the primary colour?
Why does it needs extra work then?

[skjnldsv]

server/apps/theming/lib/Themes/DefaultTheme.php

Line 193 in e4d3344

'--primary-invert-if-bright' => $this->util->invertTextColor($this->primaryColor) ? 'invert(100%)' : 'no',

[skjnldsv]

Ah, this should be properly fixed by #34437 I guess

[szaimen]

Ah, this should be properly fixed by #34437 I guess

no, not for custom background. It will probably only get fixed with #34512

[skjnldsv]

@szaimen this issue is not about custom background

[szaimen]

Ah I see.

[Pytal]

Ah, this should be properly fixed by #34437 I guess

👌

[skjnldsv]

Merged and fixed

[Pytal]

Seems that the header icons on the files page and others (excluding dashboard and appearance pages) are still not inverted