Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use color preset of shipped background as primary color #34298

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Use color preset of shipped background as primary color #34298

merged 2 commits into from
Oct 5, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Sep 28, 2022 •
edited
Loading

Brand color #0082c9 is preserved for backgrounds while #00639a is used as --color-primary for improved accessibility

@Pytal Pytal added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming labels Sep 28, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Sep 28, 2022
@Pytal Pytal requested review from skjnldsv and a team September 28, 2022 02:43
@Pytal Pytal self-assigned this Sep 28, 2022
@Pytal Pytal requested review from PVince81 and artonge and removed request for a team September 28, 2022 02:43
This was referenced Sep 28, 2022
Merged
Closed
@blizzz blizzz mentioned this pull request Sep 28, 2022
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 28, 2022
@blizzz
Copy link
Member

blizzz commented Sep 28, 2022

master is still 26, please trigger a backport if necessary

@blizzz
Copy link
Member

blizzz commented Sep 28, 2022

Also CI is unhappy

@Pytal Pytal mentioned this pull request Sep 28, 2022
Closed
@szaimen
Copy link
Contributor

szaimen commented Sep 28, 2022

/backport to stable25

@szaimen
Copy link
Contributor

szaimen commented Sep 28, 2022

Conflicts

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 28, 2022
@Pytal Pytal force-pushed the enh/shipped-background-colors branch from d2d0bee to e4f7c7f Compare September 28, 2022 19:10
szaimen
szaimen requested changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to work mostly but there seem to be some bug to happen when you change your personal theming and visit the admin theming. the primary color is then set to the one of the personal color although it should still be the default Nextcloud color IIRC
See
image

@Pytal Pytal force-pushed the enh/shipped-background-colors branch from e4f7c7f to 317e366 Compare September 29, 2022 01:38
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 29, 2022
@szaimen szaimen requested review from st3iny and removed request for st3iny September 30, 2022 15:56
st3iny
st3iny approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Idea for a followup: Make it work with custom images too.

@szaimen
Copy link
Contributor

szaimen commented Oct 1, 2022 •
edited
Loading

@Pytal Please fix the tests, if green we green we can merge

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 1, 2022
@szaimen szaimen mentioned this pull request Oct 3, 2022
Merged
3 tasks
@blizzz
Copy link
Member

blizzz commented Oct 3, 2022

/rebase

@blizzz
Copy link
Member

blizzz commented Oct 3, 2022 •
edited
Loading

looks like it needs CI fixes nevertheless

@nextcloud-command nextcloud-command force-pushed the enh/shipped-background-colors branch from 9225d01 to c6f98e2 Compare October 3, 2022 19:15
@szaimen
Copy link
Contributor

szaimen commented Oct 4, 2022

@Pytal can you please fix the CI?

@Pytal Pytal force-pushed the enh/shipped-background-colors branch 2 times, most recently from 4d75170 to 59914f3 Compare October 4, 2022 19:32
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 4, 2022
@szaimen
Copy link
Contributor

szaimen commented Oct 4, 2022

Only one test to go!

@Pytal Pytal force-pushed the enh/shipped-background-colors branch from 59914f3 to eb527ea Compare October 5, 2022 04:19
Pytal added 2 commits October 5, 2022 06:19
@Pytal
Use color preset of shipped background as primary color
e962d3f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Use brand color for background only and keep accessible color as colo…
7044191 
…r primary

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the enh/shipped-background-colors branch from eb527ea to 7044191 Compare October 5, 2022 06:19
skjnldsv
skjnldsv approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works ! 🚀

@szaimen szaimen merged commit a178d69 into master Oct 5, 2022
@szaimen szaimen deleted the enh/shipped-background-colors branch October 5, 2022 07:52
@skjnldsv skjnldsv mentioned this pull request Oct 5, 2022
Closed
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 5, 2022
Merged
@Pytal Pytal mentioned this pull request Oct 7, 2022
Closed
9 tasks
@Pytal Pytal mentioned this pull request Nov 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@st3iny st3iny st3iny approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility design Design, UI, UX, etc. feature: theming
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
6 participants
@Pytal @blizzz @szaimen @jancborchardt @st3iny @skjnldsv