Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invert header icons on bright preset backgrounds #34665

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 19, 2022

Fix #33969

Icon inversion js specific to the Dashboard and Appearance and accessibility pages has been removed in favour of instance-wide inversion

@Pytal Pytal added this to the Nextcloud 26 milestone Oct 19, 2022
@Pytal Pytal self-assigned this Oct 19, 2022
@Pytal
Copy link
Member Author

Pytal commented Oct 19, 2022

/backport to stable25

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking before #34576

@Pytal Pytal force-pushed the fix/invert-header-icons branch from dcb0fd0 to a909e47 Compare October 19, 2022 18:40
@Pytal
Copy link
Member Author

Pytal commented Oct 19, 2022

Using --background-image-invert-if-bright

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 19, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/invert-header-icons branch from a909e47 to 58abed2 Compare October 19, 2022 19:13
@Pytal Pytal merged commit 74d8365 into master Oct 19, 2022
@Pytal Pytal deleted the fix/invert-header-icons branch October 19, 2022 23:02
@szaimen
Copy link
Contributor

szaimen commented Oct 20, 2022

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: dashboard feature: theming regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header icons need to invert to black/dark on specific preset background images (like the Dashboard does)
4 participants