-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert header icons on bright preset backgrounds #34665
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
bug
design
Design, UI, UX, etc.
3. to review
Waiting for reviews
feature: theming
regression
feature: dashboard
labels
Oct 19, 2022
/backport to stable25 |
1 task
skjnldsv
approved these changes
Oct 19, 2022
nickvergessen
approved these changes
Oct 19, 2022
skjnldsv
previously requested changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking before #34576
skjnldsv
approved these changes
Oct 19, 2022
Pytal
force-pushed
the
fix/invert-header-icons
branch
from
October 19, 2022 18:40
dcb0fd0
to
a909e47
Compare
Using |
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Oct 19, 2022
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/invert-header-icons
branch
from
October 19, 2022 19:13
a909e47
to
58abed2
Compare
1 task
/backport to stable25 |
1 task
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
bug
design
Design, UI, UX, etc.
feature: dashboard
feature: theming
regression
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #33969
Icon inversion js specific to the Dashboard and Appearance and accessibility pages has been removed in favour of instance-wide inversion