Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🖼️ EXIF data display #39714

Closed
5 tasks
Tracked by #40676
AndyScherzinger opened this issue Aug 4, 2023 · 13 comments
Closed
5 tasks
Tracked by #40676

🖼️ EXIF data display #39714

AndyScherzinger opened this issue Aug 4, 2023 · 13 comments
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement ❄️ 2023-Winter
Milestone

Comments

@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 4, 2023

Simple display & ability to view. Basic expected thing but not so exciting (also fine if we do not do it)

This is more for advanced users.

  • UX design
  • tech design

we could limit this to a minimal subset like

  • the date the picture was taken
  • camera info
  • shutter speed
  • aperture
  • ISO level
  • pixels / mega pixel rate

image


For reference see Android mock / GPhotos
Screenshot_20230803_112724


Overview:

  • Extract further EXIF metadata as described above
  • Improve meta-data retrieval API for extended EXIF/image meta-data
  • Display new EXIF meta-data in photos app's sidebar
@AndyScherzinger AndyScherzinger added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 4, 2023
@tobiasKaminsky
Copy link
Member

2023-08-11-145208

This is how it looks now on Android Files, thanks to @ZetaTom 🎉

@jancborchardt
Copy link
Member

Also for reference, there is an existing metadata app: https://apps.nextcloud.com/apps/metadata
We don’t have to do it exactly like that though – this is why we have the mockup by @nimishavijay :)

@AndyScherzinger
Copy link
Member Author

@jancborchardt the top mockup doesn't tell me about the data in the collapsed section ;)

@tobiasKaminsky
Copy link
Member

Not a server/app expert, but for me code looks like that metadata is computed when clicking on tab.
So this is not helpful for clients, as those metadata is not stored in database.

Besides that I am unsure if we should "simply" show everything. This would clutter UI, with probably no real value for >90%.

@jancborchardt
Copy link
Member

jancborchardt commented Aug 30, 2023

the top mockup doesn't tell me about the data in the collapsed section ;)

@nimishavijay can you check the top post and complete the info/spec there, also in regards to that collapsed section? :)
Should probably mostly be mapped to what is shown in mobile for us (which in turn is mapped to native iOS / Google Photos), so best to look at Google Photos there?

@nimishavijay
Copy link
Member

@AndyScherzinger what information is available to show here? for camera details @tobiasKaminsky's screenshot looks perfect! Is there any other metadata available?

@AndyScherzinger
Copy link
Member Author

@nimishavijay we would stick to the exact data displayed in the clients #39714 (comment) plus the date-taken information (to be used/usable for sorting, see nextcloud/photos#87 (when the photo has been taken)

@AndyScherzinger AndyScherzinger changed the title [Photos2] 6 - Generic EXIF data display Generic EXIF data display Aug 31, 2023
@nimishavijay
Copy link
Member

nimishavijay commented Aug 31, 2023

image

image

So Google shows the details in the screenshot above.

How it could look like in Nextcloud (UPDATED)

image

  • Don't have a "Advanced details" button, since we are already in the details section, so show all items all the time
  • list of data:
    • Albums
    • Add to album button
    • Location
    • Location map
    • Taken datetime and details: "Taken on Aug 26, 2023 at 18:00" in the title and "1.2 MB · 9 MP · 2252 x 4000" on the subline
    • Camera details (items in subline separated by middle dot symbol · )
    • Add description button (nice to have)

Edit: changed mockups and specs after feedback
Edit 2: changed mockups even more, it's now very much on par with mobile clients

Old mockups![image](https://github.com/nextcloud/server/assets/52440189/a79d2dda-dd7a-4243-951b-76a1c14abdf1)

image

@AndyScherzinger
Copy link
Member Author

@nimishavijay the "Taken by [person name]" isn't possible I think. There are collaborative albums but I don't think there is a way to know who took a picture nor who uploaded it. @artonge maybe you have more info on this one, maybe there is an ownership of the file - however that still doesn't reflect the author of the photo, i.e. if I upload the pictures taken by my partner, than it didn't take them, but Nextcloud can't know about it. So I would drop this info from the list.

@nimishavijay
Copy link
Member

Done, updated mockups. They should be good to go now 🚀

@AndyScherzinger
Copy link
Member Author

@nimishavijay just for reference, this is the current implementation on Android Files (without the location, since that is my personal location)

Screenshot_20230831_194857

@AndyScherzinger AndyScherzinger changed the title Generic EXIF data display 🖼️ Generic EXIF data display Sep 5, 2023
@AndyScherzinger AndyScherzinger changed the title 🖼️ Generic EXIF data display 🖼️ EXIF data display Sep 6, 2023
@artonge
Copy link
Contributor

artonge commented Nov 14, 2023

@nimishavijay @jancborchardt

The display of EXIF data are in. Design wise it is really close to the mockups, but feel free to give some feedbacks.
Note that:

  1. I skipped the album and description part. I discussed it with @AndyScherzinger, and he's fine with it.
  2. From what I understood, the tab should only be shown in the Photos app. Is that right or should it be visible from the Files app too?

@artonge
Copy link
Contributor

artonge commented Nov 16, 2023

Closing. Feel free to open new issues changes are wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement ❄️ 2023-Winter
Projects
Archived in project
Archived in project
Development

No branches or pull requests

5 participants