Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video sizing on the public share page #603

Closed
jancborchardt opened this issue Jul 27, 2016 · 4 comments · Fixed by #625
Closed

Video sizing on the public share page #603

jancborchardt opened this issue Jul 27, 2016 · 4 comments · Fixed by #625
Labels
design Design, UI, UX, etc. enhancement feature: sharing
Milestone
Nextcloud 11.0

Comments

@jancborchardt
Copy link
Member

When sharing a video via link, the size of the video container should be the same as the video, or maximally the width of the viewport. Currently it looks like this:
capture du 2016-07-27 14-47-01
(Whereas the actual video is a lot bigger.)

cc @oparoz @Instagit @schiessle
@jancborchardt jancborchardt added enhancement design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of feature: sharing labels Jul 27, 2016
@icewind1991
Copy link
Member

No way around this really since we don't know the video size until we start playing

@jancborchardt
Copy link
Member Author

Maybe then we should up the default size to something more reasonable or bigger? What’s a good default? Maybe 1280*720, or maximum the width of the viewport? cc @MorrisJobke

@jancborchardt
Copy link
Member Author

Youtube default seems to be 854*480px, we could go for that.

jancborchardt added a commit that referenced this issue Jul 28, 2016
@jancborchardt
up the minimum size of the public share video a bit, use 16/9 ratio, fix
8a305c4 
 #603
@jancborchardt jancborchardt mentioned this issue Jul 28, 2016
Merged
@jancborchardt
Copy link
Member Author

Fix at #625

jancborchardt added a commit that referenced this issue Jul 29, 2016
@jancborchardt
up the minimum size of the public share video a bit, use 16/9 ratio, fix
e92723d 
 #603
jancborchardt added a commit that referenced this issue Jul 29, 2016
@jancborchardt
up the minimum size of the public share video a bit, use 16/9 ratio, fix
748745d 
 #603
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Jul 29, 2016
jancborchardt added a commit that referenced this issue Jul 29, 2016
@jancborchardt
up the minimum size of the public share video a bit, use 16/9 ratio, fix
0d5b8f3 
 #603
GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this issue Aug 30, 2016
@jancborchardt
up the minimum size of the public share video a bit, use 16/9 ratio, fix
926f071 
 nextcloud#603
@MorrisJobke MorrisJobke removed the 1. to develop Accepted and waiting to be taken care of label Feb 21, 2017
@nextcloud-bot nextcloud-bot mentioned this issue Aug 10, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Sep 26, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this issue Nov 8, 2018
Closed
@yesiamdollar yesiamdollar mentioned this issue Nov 28, 2023
Open
@yesiamdollar yesiamdollar mentioned this issue Dec 14, 2023
Open
@yesiamdollar yesiamdollar mentioned this issue Dec 31, 2023
Open
@yesiamdollar yesiamdollar mentioned this issue Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design Design, UI, UX, etc. enhancement feature: sharing
Projects
None yet
Milestone
Nextcloud 11.0
Development

Successfully merging a pull request may close this issue.

up the minimum size of the public share video a bit, use 16/9 ratio nextcloud/server
3 participants
@MorrisJobke @jancborchardt @icewind1991