-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
up the minimum size of the public share video a bit, use 16/9 ratio #625
Conversation
@jancborchardt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @MorrisJobke and @oparoz to be potential reviewers |
@jancborchardt Does it work nicely on mobile? |
@oparoz yep it does – you can simply make your window smaller to test. :) That’s also why I chose the smaller 427 * 240px instead of the full 854 * 480px. It will always use maximally 100% of the viewport width. |
Shouldn't this be min-width/height? |
@icewind1991 no, because then on mobile when the screen is smaller than this it will cause scrolling. |
Sooo – @oparoz @icewind1991 can you actually test this and give it thumbs up? ;D |
Also set max-width 100% Imo this is to small for non mobile screens |
8a305c4
to
e92723d
Compare
e92723d
to
748745d
Compare
Seems there was some inline stuff setting other max-widths which messed it up. Needed to add |
A lot better now 👍 Works |
👍 |
@karlitschek Port to stable10? |
I’d say it’s a nice detail/fix for sharing and a backport would be cool. |
nice. please backport 👍 |
Backport at #668 |
up the minimum size of the public share video a bit, use 16/9 ratio
fix #603 – ended up using half the size of Youtube’s 854*480px since that is a bit too big.
Please review @icewind1991 @oparoz @schiessle