-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7.0+ for Nextcloud 14 #7368
Comments
Even 7.0 has only 11 month left -> http://php.net/supported-versions.php |
@splitt3r We have to check the supported situation in distribution. Which is usually different then from upstream. |
O.K. Let's move to 7.0+ for 14 |
Oye! NOW the fun stuff starts? ;-) |
Our goal is to have a supported version on which Nextcloud runs on all major distributions. Because this is the place where Nextcloud runs and it would not make it easier to get Nextcloud running if you need to find 3rdparty packages or compile PHP yourself. (Not even thinking about security and upgrade problems afterwards with those setups). |
Yes please. I think this can really harden our software! I'm fine with 7.0 for now. We can review for 15 what the state is then. |
In NC13, could we put in a notification/warning on the admin page for users with PHP<7.0 that this is the last version supporting php 5.6 and that PHP 7.0+ is required for the next major release? This way they are noticed early enough to plan an upgrade. |
Could you make a ticket for this. You could also assign me there. Thanks |
* Uses PHPUnit 6.5 (requires PHP 7.0+, but we got rid with NC 14 (see nextcloud/server#7368) * Namespaces are rewritten * If composer isn't installed, it installs it (taken from nextcloud/news) Signed-off-by: Thomas Citharel <tcit@tcit.fr>
* Uses PHPUnit 6.5 (requires PHP 7.0+, but we got rid with NC 14 (see nextcloud/server#7368) * Namespaces are rewritten * If composer isn't installed, it installs it (taken from nextcloud/news) Signed-off-by: Thomas Citharel <tcit@tcit.fr> Remove PHPUnit Download in CI Signed-off-by: Thomas Citharel <tcit@tcit.fr> Properly handle phpunit on travis for 5.6 Signed-off-by: Thomas Citharel <tcit@tcit.fr> Remove trouble composer.lock Signed-off-by: Thomas Citharel <tcit@tcit.fr> Don't install composer deps twice on CI Signed-off-by: Thomas Citharel <tcit@tcit.fr>
I want to bring up the topic of raising the PHP version to 7.0. I collected a list of released PHP packages for the main distributions:
As you need to use RHSCL anyways on Red Hat to run Nextcloud 13 and before, it only make sense to also raise the required version for Nextcloud. The main reason behind this is proper type hinting of scalar types as well as strict typing. Just today there was another possible bug that would have been found by our CI if strict typing would be set: #7351 (comment)
Compare https://3v4l.org/dmBJK (without strict typing) to https://3v4l.org/msAEZ (with strict typing).
Opinions on this? I guess it is a good way to move forward with our quality goals.
cc @rullzer @LukasReschke @schiessle @karlitschek @blizzz @skjnldsv @juliushaertl @icewind1991 @ChristophWurst @daita @danxuliu
The text was updated successfully, but these errors were encountered: