use formal version of German by default #7351

schiessle · 2017-11-30T11:51:26Z

Use formal version of German by default, if not explicitly defined differently.

Germans are sometimes a bit old school and prefer the formal "Sie" instead of "Du". 😉 So I think it makes sense to use this version as default if the browser is set to German.

codecov · 2017-11-30T12:23:54Z

Codecov Report

Merging #7351 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #7351      +/-   ##
============================================
+ Coverage     50.91%   50.92%   +<.01%     
- Complexity    24698    24704       +6     
============================================
  Files          1586     1586              
  Lines         94113    94125      +12     
  Branches       1361     1361              
============================================
+ Hits          47920    47929       +9     
- Misses        46193    46196       +3

Impacted Files	Coverage Δ	Complexity Δ
config/config.sample.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
lib/private/L10N/Factory.php	`72.22% <100%> (+1.63%)`	`72 <5> (+5)`	⬆️
apps/files_trashbin/lib/Trashbin.php	`72.28% <0%> (-0.25%)`	`136% <0%> (ø)`
lib/private/legacy/util.php	`58.65% <0%> (-0.03%)`	`225% <0%> (+1%)`

rullzer

Please no. This will lead to a world of pain if we are going to do such weird fallbacks for every other language.

If people want the formal German they should set their browser/os properly. Or else set it in the settings.

schiessle · 2017-11-30T12:33:00Z

The problem is that the browser sends per default "de" and not "de_DE". At least Firefox, but from user feedback this is also true for other browsers. So it is not the users fault who can't know our internal hack and who set the browser correctly to German but didn't get the expected result. As the whole "de" vs "de_DE" hack is our "fault" I think it is also our responsibility to pick the right one if the browser is set to German. And the default should definitely be the formal one. Nobody is offended by calling them "Sie" but many are offended by calling them "Du"

schiessle · 2017-11-30T12:39:25Z

Added @MorrisJobke and @blizzz as additional reviewers because I think that's a quite "German problem" 😉

rullzer · 2017-11-30T12:54:54Z

You can also set German/Germany (de_DE) in firefox. I see no reason to prefer German/Germany over German/Liechtenstein here.

blizzz · 2017-11-30T13:06:50Z

And the default should definitely be the formal one. Nobody is offended by calling them "Sie" but many are offended by calling them "Du"

Well… I would not sign this for Berlin :)

Silly language you have. Do as you please.

MorrisJobke · 2017-11-30T13:40:40Z

lib/private/L10N/Factory.php

@@ -159,6 +159,8 @@ public function findLanguage($app = null) {
 try {
 // Try to get the language from the Request
 $lang = $this->getLanguageFromRequest($app);
+ // use formal version of german ("Sie" instead of "Du") by default
+ $lang = strtolower($lang) === 'de' ? 'de_DE' : $lang;


Then don't do this here, but in the actual method that sets it during the first login.

I'd say this should go into getLanguageFromRequest, so it still works for guests.
But I'd really like to see this optional.

MorrisJobke · 2017-11-30T13:43:23Z

Germans are sometimes a bit old school and prefer the formal "Sie" instead of "Du". 😉 So I think it makes sense to use this version as default if the browser is set to German.

If we do this at all, we should only change this during the first login, otherwise this method has some erratic behaviour. We should set it to de_DE for all users that come along with de and they can switch back afterwards in the settings, because this is the order as of now:

user settings
browser default
instance default

nickvergessen · 2017-11-30T14:02:58Z

I don't really think we should autocorrect user preferences.
If you tell your browser use "de" we shouldn't say "you probably mean de_DE, although you could have selected that instead"?

Currently the priority is: force_lang > user preference > request lang > default_lang > en

I really really really do not want to have all people seeing the formal german on all the instances by default. This is really a minority, so either patch or config for them, but no way distance-by-default.

nickvergessen · 2017-11-30T14:04:20Z

I guess the main issue here is "Guests" in which case the "solution" of Morris also wouldn't work, because it only works on login?

schiessle · 2017-11-30T14:10:52Z

If you tell your browser use "de" we shouldn't say "you probably mean de_DE, although you could have selected that instead"?

This implies that the user knows that "de" is the non-formal version and de_DE is the formal version which I don't think is common sense outside of the Nextcloud universe.

But I like your idea to also look at the default_language and only do it if this is set to de_DE... I will add it. Thanks for this really good suggestion

schiessle · 2017-11-30T14:38:38Z

@nickvergessen @MorrisJobke @rullzer updated, I think this is now a really good solution.

nickvergessen · 2017-11-30T14:49:31Z

lib/private/L10N/Factory.php

 try {
 // Try to get the language from the Request
 $lang = $this->getLanguageFromRequest($app);
+ // use formal version of german ("Sie" instead of "Du") if the default
+ // language is set to 'de_DE'
+ if (strtolower($lang) === 'de' && strtolower($defaultLanguage) === 'de_de') {


I think we should try to move this into getLanguageFromRequest
or at least check languageExists because if de exists, but de_DE not (lets say for an app), it would fail

@nickvergessen moved it to getLanguageFromRequest

jancborchardt · 2017-11-30T16:17:15Z

So, with the updated behavior the default for Germans is still the friendlier informal way, unless specifically set to de_DE in system-wide settings or Nextcloud itself?

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle · 2017-11-30T16:30:15Z

So, with the updated behavior the default for Germans is still the friendlier informal way, unless specifically set to de_DE in system-wide settings or Nextcloud itself?

exactly, only if the admin sets 'default_language' to 'de_DE' in the config.php, it will be preferred.

MorrisJobke · 2017-12-01T11:07:28Z

exactly, only if the admin sets 'default_language' to 'de_DE' in the config.php, it will be preferred.

Could you document this in the sample config? Then I'm fine with this here 👍

MorrisJobke · 2017-12-01T11:08:32Z

lib/private/L10N/Factory.php

+ // use formal version of german ("Sie" instead of "Du") if the default
+ // language is set to 'de_DE' if possible
+ if (strtolower($lang) === 'de'
+ && strtolower($defaultLanguage) === 'de_de' &&


And please check this variable first - https://3v4l.org/msAEZ (totally fine for now, but let's fix it upfront: https://3v4l.org/dmBJK)

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle · 2017-12-01T15:16:27Z

@MorrisJobke documentation added 😃

rullzer

This version I can deal with 😉

schiessle added the 3. to review Waiting for reviews label Nov 30, 2017

schiessle added this to the Nextcloud 13 milestone Nov 30, 2017

schiessle requested review from rullzer and nickvergessen November 30, 2017 11:51

schiessle force-pushed the change-default-german-language branch from 0be9cb5 to 7d4df77 Compare November 30, 2017 11:54

rullzer previously requested changes Nov 30, 2017

View reviewed changes

schiessle requested review from MorrisJobke and blizzz November 30, 2017 12:38

MorrisJobke reviewed Nov 30, 2017

View reviewed changes

schiessle force-pushed the change-default-german-language branch 2 times, most recently from 1207187 to a37f701 Compare November 30, 2017 14:38

schiessle force-pushed the change-default-german-language branch from a37f701 to a479535 Compare November 30, 2017 14:44

nickvergessen reviewed Nov 30, 2017

View reviewed changes

use formal version of German if default_language is set to 'de_DE'

8b73434

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

schiessle force-pushed the change-default-german-language branch from a479535 to 8b73434 Compare November 30, 2017 16:29

jancborchardt approved these changes Nov 30, 2017

View reviewed changes

MorrisJobke reviewed Dec 1, 2017

View reviewed changes

schiessle added 2 commits December 1, 2017 16:14

check if $defaultLanguage is a valid string before we move on

2c3d97c

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

update documentation

3578acb

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

MorrisJobke mentioned this pull request Dec 3, 2017

PHP 7.0+ for Nextcloud 14 #7368

Closed

rullzer approved these changes Dec 6, 2017

View reviewed changes

rullzer merged commit 6e45034 into master Dec 6, 2017

rullzer deleted the change-default-german-language branch December 6, 2017 07:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use formal version of German by default #7351

use formal version of German by default #7351

schiessle commented Nov 30, 2017

codecov bot commented Nov 30, 2017 •

edited

Loading

rullzer left a comment

schiessle commented Nov 30, 2017 •

edited

Loading

schiessle commented Nov 30, 2017

rullzer commented Nov 30, 2017

blizzz commented Nov 30, 2017

MorrisJobke Nov 30, 2017

nickvergessen Nov 30, 2017

MorrisJobke commented Nov 30, 2017

nickvergessen commented Nov 30, 2017 •

edited

Loading

nickvergessen commented Nov 30, 2017

schiessle commented Nov 30, 2017 •

edited

Loading

schiessle commented Nov 30, 2017

nickvergessen Nov 30, 2017

schiessle Nov 30, 2017

jancborchardt commented Nov 30, 2017

schiessle commented Nov 30, 2017 •

edited

Loading

MorrisJobke commented Dec 1, 2017

MorrisJobke Dec 1, 2017

schiessle Dec 1, 2017

schiessle commented Dec 1, 2017

rullzer left a comment

use formal version of German by default #7351

use formal version of German by default #7351

Conversation

schiessle commented Nov 30, 2017

codecov bot commented Nov 30, 2017 • edited Loading

Codecov Report

rullzer left a comment

Choose a reason for hiding this comment

schiessle commented Nov 30, 2017 • edited Loading

schiessle commented Nov 30, 2017

rullzer commented Nov 30, 2017

blizzz commented Nov 30, 2017

MorrisJobke Nov 30, 2017

Choose a reason for hiding this comment

nickvergessen Nov 30, 2017

Choose a reason for hiding this comment

MorrisJobke commented Nov 30, 2017

nickvergessen commented Nov 30, 2017 • edited Loading

nickvergessen commented Nov 30, 2017

schiessle commented Nov 30, 2017 • edited Loading

schiessle commented Nov 30, 2017

nickvergessen Nov 30, 2017

Choose a reason for hiding this comment

schiessle Nov 30, 2017

Choose a reason for hiding this comment

jancborchardt commented Nov 30, 2017

schiessle commented Nov 30, 2017 • edited Loading

MorrisJobke commented Dec 1, 2017

MorrisJobke Dec 1, 2017

Choose a reason for hiding this comment

schiessle Dec 1, 2017

Choose a reason for hiding this comment

schiessle commented Dec 1, 2017

rullzer left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 30, 2017 •

edited

Loading

schiessle commented Nov 30, 2017 •

edited

Loading

nickvergessen commented Nov 30, 2017 •

edited

Loading

schiessle commented Nov 30, 2017 •

edited

Loading

schiessle commented Nov 30, 2017 •

edited

Loading