Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication of file assembling in chunked upload via web #9554

Closed
rullzer opened this issue May 23, 2018 · 9 comments · Fixed by #11112
Closed

No indication of file assembling in chunked upload via web #9554

rullzer opened this issue May 23, 2018 · 9 comments · Fixed by #11112
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: files
Milestone

Comments

@rullzer
Copy link
Member

rullzer commented May 23, 2018

  1. Upload a big file via the web (2GB or something)
  2. See it upload
  3. Once the final byte is send the upload bar disappears
  4. The file still needs to be assembled which takes time
  5. The file list is refreshed

Now at step 4 we have no feedback that something is still going on. But assembling a 2GB file can take some time.

Possible solutions:

  1. Show a spinner?
  2. Don't remove the progress bar until it is all finished
@rullzer rullzer added enhancement 1. to develop Accepted and waiting to be taken care of labels May 23, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone May 23, 2018
@MorrisJobke
Copy link
Member

I would vote for showing a placeholder entry in the file list - maybe also already all of the time. Then it's also easier to align with the "upload to a folder", which shows below the folder name some information.

@skjnldsv
Copy link
Member

Maybe it's time to just change the progress bar we have 🙈

@c0fe
Copy link

c0fe commented May 23, 2018

Honestly, the whole upload mechanism design is a mess. I proposed that the upload show a modal window at the bottom but I do not recall where that conversation went.

@MorrisJobke how about doing it this way

User selects file to upload
Name of file appears in gray on the UI with smaller font
Progress bar appears below the file name (using the color scheme selected by admin)
File completes upload
Progress bar disappears and file description turns black and restores to original size.

The restoration I suggest is using how Material Design does it with forms, where if you click on the field the description goes up a bit smaller.

@skjnldsv

For drop box file I would just recommend forking the Mega UI as their upload mechanism is very good.

@MorrisJobke
Copy link
Member

cc @nextcloud/designers

I like the proposal of @c0fe

@skjnldsv
Copy link
Member

Seconded

@jancborchardt
Copy link
Member

Basically agree with @MorrisJobke and @c0fe, and this has come up before but also not sure where it was:
When you upload files, simply show »Ghost entries« in the file list, with 50% opacity. The whole file row can act as the progress bar for uploading. Of course the filetype icon should also be a spinner, because maybe only one file has actual progress.
Then as soon as it’s uploaded, it goes from 50% to full opacity, and the spinner becomes the image preview.

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 28, 2018
@MorrisJobke
Copy link
Member

Most likely nothing for 14 -> moving to 15.

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jul 11, 2018
@jancborchardt
Copy link
Member

I found the issue: [IMPROVEMENT] Better Upload for Single Files #8972

The uploading file should actually just show inline, using the file row as loading indicator.

and

  • navigating further down into folders: We could show the progress bar below the folder name in the breadcrumbs
  • navigating further up to parent folders: We could show the progress bar below the folder name in the file list

That way it will be nicely integrated and not just slapped on the bottom.

@jancborchardt jancborchardt added design Design, UI, UX, etc. feature: files labels Jul 19, 2018
@MorrisJobke
Copy link
Member

Just some notes from my side:

It’s kind of a bug: the upload bar is gone and the user think it’s finished but it isn’t fully, because the MOVE request isn’t done yet. So we maybe should look into make this a bit smoother.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. feature: files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants