Do not hide the progress bar while the chunked upload is being assembled #11112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large files are not uploaded in a single operation, but uploaded in several chunks; once all the chunks are uploaded then the server needs to assemble them to get the final file. Before, once the chunks were uploaded the progress bar was hidden. However, this was confusing for the users, as the file could still need some time to appear in the file list due to the assembling. Now once all the chunks are uploaded the text in the progress bar changes to inform the user that there are still some pending operations, and only when the file is finally assembled the progress bar is hidden. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
MorrisJobke
deleted the
do-not-hide-the-progress-bar-while-the-chunked-upload-is-being-assembled
branch
|
@danxuliu Could you backport this to stable14? |
Sure; I intended to backport it to stable13 too, should I do it only for stable14? |
Fine with me to backport it to both. |
This was referenced Sep 26, 2018
Done :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9554
Large files are not uploaded in a single operation, but uploaded in several chunks; once all the chunks are uploaded then the server needs to assemble them to get the final file.
Before, once the chunks were uploaded the progress bar was hidden. However, this was confusing for the users, as the file could still need some time to appear in the file list due to the assembling. Now once all the chunks are uploaded the text in the progress bar changes to inform the user that there are still some pending operations, and only when the file is finally assembled the progress bar is hidden.
How to test:
sleep(10);toperformMovein ChunkingPlugin.phpCurrent result:
The text in the progress bar changes to Processing files... when all the chunks are uploaded, and it is hidden once the move finishes and the file appears in the file list.
Previous result:
The progress bar was hidden as soon as all the chunks were uploaded, and after some seconds the file appeared in the file list.
Reviewers, if you cancel a chunked upload you will notice that it does not work as expected; it is a known problem and it will be fixed in a different pull request.
@nextcloud/javascript