Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus comment on tabs select + design fixes #10327

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Focus comment on tabs select + design fixes #10327

merged 2 commits into from
Jul 24, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 21, 2018 •
edited
Loading

Fix #8718

Before
kazam_screenshot_00002

After
capture d ecran 2018-07-21 18 24 32

@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. feature: comments labels Jul 21, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Jul 21, 2018
@skjnldsv skjnldsv self-assigned this Jul 21, 2018
MorrisJobke
MorrisJobke approved these changes Jul 24, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works 👍

skjnldsv added 2 commits July 24, 2018 12:34
@skjnldsv @rullzer
Focus the comment input on tab select/loading
b7317a3 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv @rullzer
Fixed comments design
52af49e 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@rullzer rullzer force-pushed the focus-comment-on-tabs-select branch from efd4105 to 52af49e Compare July 24, 2018 10:34
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 24, 2018
@skjnldsv
Copy link
Member Author

sh: 1: kill: No such process
Unrelated, to release!

@MorrisJobke MorrisJobke merged commit e8b0868 into master Jul 24, 2018
@MorrisJobke MorrisJobke deleted the focus-comment-on-tabs-select branch July 24, 2018 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. feature: comments papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @rullzer @MorrisJobke