Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus comment on tabs select + design fixes #10327

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Focus comment on tabs select + design fixes #10327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7317a3
Focus the comment input on tab select/loading
skjnldsv Jul 21, 2018
52af49e
Fixed comments design
skjnldsv Jul 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 22 additions & 24 deletions apps/comments/css/comments.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,39 +14,37 @@

#commentsTabView .newCommentForm {
margin-left: 36px;
position: relative;
}

#commentsTabView .newCommentForm .message {
/* width = 100% - (width of submit button (44px) + margin (3px) + border (1px)) */
width: calc(100% - 48px);
/* Need to use float left instead of display inline-block because Safari shows a big cursor */
float: left;
/* To align it to the button on the side */
margin-top: 5px;
width: 100%;
padding: 10px;
min-height: 44px;
margin: 0;
}

#commentsTabView .newCommentForm .submit {
width: 44px;
margin: 0;
padding: 13px;
background-color: transparent;
border: none;
opacity: .3;
vertical-align: bottom;
#commentsTabView .newCommentForm {
.submit,
.submitLoading {
width: 44px;
height: 44px;
margin: 0;
padding: 13px;
background-color: transparent;
border: none;
opacity: .3;
position: absolute;
bottom: 0;
right: 0;
}
}

#commentsTabView .deleteLoading {
float: right;
padding: 14px;
vertical-align: middle;
}

#commentsTabView .submitLoading {
vertical-align: bottom;
display: inline-block;
padding: 14px;
}

#commentsTabView .newCommentForm .submit:not(:disabled):hover,
#commentsTabView .newCommentForm .submit:not(:disabled):focus {
opacity: 1;
Expand All @@ -65,9 +63,6 @@
position: relative;
/** padding bottom is little more so that the top and bottom gap look uniform **/
padding: 10px 0px 15px;
word-wrap: break-word;
overflow-wrap: break-word;
overflow: hidden;
}

#commentsTabView .comments .comment {
Expand Down Expand Up @@ -201,6 +196,9 @@

#commentsTabView .comments > li:not(.newCommentRow) .message {
padding-left: 40px;
word-wrap: break-word;
overflow-wrap: break-word;
overflow: hidden;
}

#commentsTabView .comment .action {
Expand Down
3 changes: 3 additions & 0 deletions apps/comments/js/commentstabview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@
this.$el.find('.message').on('keydown input change', this._onTypeComment);

autosize(this.$el.find('.newCommentRow .message'))
this.$el.find('.newCommentForm .message').focus();
},

_initAutoComplete: function($target) {
Expand Down Expand Up @@ -303,6 +304,8 @@
}
);
}
this.$el.find('.newCommentForm .message').focus();

},

/**
Expand Down