Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linebreak on public share page #10850

Closed
wants to merge 0 commits into from
Closed

fix linebreak on public share page #10850

wants to merge 0 commits into from

Conversation

violoncelloCH
Copy link
Member

in text "Get your own free account"
fixes #10849

@MorrisJobke
Copy link
Member

That's the one @tobiasKaminsky also experienced. @jancborchardt @skjnldsv Is this how you want it?

@MorrisJobke MorrisJobke added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 25, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Aug 25, 2018
@MorrisJobke MorrisJobke mentioned this pull request Aug 26, 2018
6 tasks
@tobiasKaminsky
Copy link
Member

@MorrisJobke no, my problem is that on the border there is a link to the current page, and a little bit below there is then the link to /signup.
--> I'll create an issue.

@tobiasKaminsky
Copy link
Member

After testing this PR with Julius, I can confirm that this is working now as expected.
The other issue is #10024, where the Cloud name points all the time to the current page, when no theming url is set.

👍

@juliusknorr
Copy link
Member

@violoncelloCH Can you add the missing sign-off message to your commit? Otherwise this looks good 👍

@violoncelloCH
Copy link
Member Author

@juliushaertl do I just have to add the line to the commit or does the commit have to be signed with my pgp key? Because this one was created with over github web and therefore is signed with githubs key.
Otherwise I think I would have to create a new pull request.

@juliusknorr
Copy link
Member

@violoncelloCH The line needs to be added to your commit message.

@violoncelloCH
Copy link
Member Author

@juliushaertl sorry, I'm a beginner with git... I try to find a way to do this

@violoncelloCH
Copy link
Member Author

violoncelloCH commented Aug 27, 2018

managed to do a rebase, create a new signed commit locally and pushed it but only to a new branch
created a new pr with the same changes but signed and with the signed-off-by line in #10878
@juliushaertl @tobiasKaminsky could you "reapprove" the new pr? sorry for any inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

public share footer linebreak in "Get your own free account"
4 participants