-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix linebreak on public share page #10850
Conversation
That's the one @tobiasKaminsky also experienced. @jancborchardt @skjnldsv Is this how you want it? |
@MorrisJobke no, my problem is that on the border there is a link to the current page, and a little bit below there is then the link to /signup. |
After testing this PR with Julius, I can confirm that this is working now as expected. 👍 |
@violoncelloCH Can you add the missing sign-off message to your commit? Otherwise this looks good 👍 |
@juliushaertl do I just have to add the line to the commit or does the commit have to be signed with my pgp key? Because this one was created with over github web and therefore is signed with githubs key. |
@violoncelloCH The line needs to be added to your commit message. |
@juliushaertl sorry, I'm a beginner with git... I try to find a way to do this |
managed to do a rebase, create a new signed commit locally and pushed it but only to a new branch |
in text "Get your own free account"
fixes #10849