-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix linebreak on public share page #10878
Conversation
I'd like to get @skjnldsv to have a look as well, maybe there was a reason for the +/-13px |
@jancborchardt you and @skjnldsv discussed about this quite heavily ... could you have a look at this please. |
@juliushaertl @MorrisJobke this is what I talked to you about. Basically this is to allow links to have a bigger clickable area, but css can go 💥 with those kind of 'hacks' |
I know, but as this was a longer offline discussion I would like to have it written down here as well and to get to a common conclusion and not just merge the stuff without have a common view. |
@jancborchardt did you fix this in a different PR yesterday? |
@rullzer I think @juliushaertl at least startet with a fix in #10912 |
You are referring to #11499 |
And yes - this is fixed by #11499. |
And also for the record – the padding is intended, for better clickability. And the negative margin is needed to make the text flow ok again left and right. Yes it can use improvement, but let’s not remove it. :) |
same changes as in #10850 but hopefully correctly signed off this time
fixes #10849
Signed-off-by: Jonas Sulzer jonas@violoncello.ch