Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linebreak on public share page #10878

Closed
wants to merge 1 commit into from
Closed

fix linebreak on public share page #10878

wants to merge 1 commit into from

Conversation

violoncelloCH
Copy link
Member

@violoncelloCH violoncelloCH commented Aug 27, 2018

same changes as in #10850 but hopefully correctly signed off this time
fixes #10849
Signed-off-by: Jonas Sulzer jonas@violoncello.ch

Signed-off-by: Jonas Sulzer <jonas@violoncello.ch>
@juliusknorr
Copy link
Member

I'd like to get @skjnldsv to have a look as well, maybe there was a reason for the +/-13px

@juliusknorr juliusknorr added design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Aug 27, 2018
@MorrisJobke
Copy link
Member

@jancborchardt you and @skjnldsv discussed about this quite heavily ... could you have a look at this please.

@skjnldsv
Copy link
Member

@juliushaertl @MorrisJobke this is what I talked to you about. Basically this is to allow links to have a bigger clickable area, but css can go 💥 with those kind of 'hacks'

@MorrisJobke
Copy link
Member

@juliushaertl @MorrisJobke this is what I talked to you about. Basically this is to allow links to have a bigger clickable area, but css can go 💥 with those kind of 'hacks'

I know, but as this was a longer offline discussion I would like to have it written down here as well and to get to a common conclusion and not just merge the stuff without have a common view.

@rullzer
Copy link
Member

rullzer commented Oct 2, 2018

@jancborchardt did you fix this in a different PR yesterday?

@violoncelloCH
Copy link
Member Author

@rullzer I think @juliushaertl at least startet with a fix in #10912

@MorrisJobke
Copy link
Member

@jancborchardt did you fix this in a different PR yesterday?

You are referring to #11499

@MorrisJobke
Copy link
Member

And yes - this is fixed by #11499.

@MorrisJobke MorrisJobke closed this Oct 2, 2018
@jancborchardt
Copy link
Member

And also for the record – the padding is intended, for better clickability. And the negative margin is needed to make the text flow ok again left and right. Yes it can use improvement, but let’s not remove it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

public share footer linebreak in "Get your own free account"
6 participants